From: Andi Kleen <andi@firstfloor.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH] dump_stack on panic
Date: Wed, 31 Oct 2007 12:53:08 +0100 [thread overview]
Message-ID: <20071031115308.GC27084@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0710310729130.13523@gandalf.stny.rr.com>
I suspect most of the panics you cited are unnecessary and should
be revisited anyways. Linux should be far beyond the "we left out error
handling and put in panic instead" philosophy of classical Unix now
and those are mostly just some left overs. But that's a different issue.
> IMHO I believe we should do the dump_stack now, and come up with another
> solution to the mount root panic.
You mean never. You want the change, you do it please properly the first
time. Doing stack dumps on no root or machine check is utterly wrong.
It is bad enough we always get them on OOM events where they are also
mostly pointless.
-Andi
next prev parent reply other threads:[~2007-10-31 11:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 0:02 [PATCH] dump_stack on panic Steven Rostedt
2007-10-31 0:14 ` Andi Kleen
2007-10-31 0:30 ` Steven Rostedt
2007-10-31 8:15 ` Christoph Hellwig
2007-10-31 10:17 ` Ingo Molnar
2007-10-31 10:41 ` Andi Kleen
2007-10-31 10:58 ` Steven Rostedt
2007-10-31 11:17 ` Andi Kleen
2007-10-31 11:39 ` Steven Rostedt
2007-10-31 11:53 ` Andi Kleen [this message]
2007-10-31 14:19 ` Arjan van de Ven
2007-10-31 15:00 ` Steven Rostedt
2007-10-31 16:28 ` Arjan van de Ven
2007-10-31 16:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031115308.GC27084@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox