public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
	Kay Sievers <kay.sievers@vrfy.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysfs: add filter function to groups
Date: Wed, 31 Oct 2007 10:29:43 -0700	[thread overview]
Message-ID: <20071031172943.GA29492@kroah.com> (raw)
In-Reply-To: <1193841484.3411.8.camel@localhost.localdomain>

On Wed, Oct 31, 2007 at 09:38:04AM -0500, James Bottomley wrote:
> On Tue, 2007-10-30 at 20:55 -0700, Greg KH wrote:
> > OSame problem here, if grp->is_visible is not set, sysfs_add_file() would
> > never be called, right?
> > 
> > Other than the logic problem (I think), I have no issue with this idea
> > at all.  Care to redo this so it works?
> 
> It's a fair cop govenor ... new patch attached.

Much better, thanks :)

I have no problem with this, if you want to take this in your tree,
please do and feel free to add:
	Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

to it, or I can take it in mine.

thanks,

greg k-h

  reply	other threads:[~2007-10-31 17:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 15:16 [PATCH] sysfs: add filter function to groups James Bottomley
2007-10-29 16:54 ` Kay Sievers
2007-10-29 16:57   ` James Bottomley
2007-10-29 17:18     ` Cornelia Huck
2007-10-29 17:24       ` James Bottomley
2007-10-29 17:27         ` Jeff Garzik
2007-10-29 17:29           ` James Bottomley
2007-10-30  9:00             ` Cornelia Huck
2007-10-30  8:55         ` Cornelia Huck
2007-10-29 17:27     ` Kay Sievers
2007-10-29 17:28       ` James Bottomley
2007-10-29 17:43         ` Kay Sievers
2007-10-29 17:58     ` Stefan Richter
2007-10-29 18:12       ` James Bottomley
2007-10-30 18:25       ` James Bottomley
2007-10-30 19:31         ` Stefan Richter
2007-10-30 19:47         ` Kay Sievers
2007-10-31  0:40         ` Mark M. Hoffman
2007-10-31  2:01           ` Kay Sievers
2007-10-31 11:28             ` Mark M. Hoffman
2007-10-31  3:55         ` Greg KH
2007-10-31  9:41           ` Cornelia Huck
2007-10-31  9:52             ` Stefan Richter
2007-10-31 10:20               ` Cornelia Huck
2007-10-31 10:37                 ` Stefan Richter
2007-10-31 12:19                   ` Cornelia Huck
2007-10-31 14:38           ` James Bottomley
2007-10-31 17:29             ` Greg KH [this message]
2007-11-04 14:12               ` James Bottomley
2007-11-04 19:06                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071031172943.GA29492@kroah.com \
    --to=greg@kroah.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox