Re: [PATCH] sysfs: add filter function to groups

James Bottomley
2007-10-29T18:12:48Z

On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote:
> James Bottomley wrote:
> >> > struct attribute_group {
> >> > const char *name;
> >> > + int (*filter_show)(struct kobject *, int);
>
> > Actually, it returns a true/false value indicating whether the given
> > attribute should be displayed.
>
> How about this:
>
> int (*is_visible)(...);
> or
> bool (*shall_be_shown)(...);
> or
> bool (*should_be_displayed)(...);
>
> or whatever, so that it indicates that this function merely answers a
> question, but doesn't filter nor show anything.

Actually, as long as it's descriptive, I really don't care about the
name. Can we all agree on "is_visible"?

James