* 2.4.24-rc1-git: crash on shutdown/unmount?
@ 2007-10-31 19:17 Alistair John Strachan
2007-10-31 19:20 ` Jens Axboe
2007-11-01 10:51 ` Jens Axboe
0 siblings, 2 replies; 6+ messages in thread
From: Alistair John Strachan @ 2007-10-31 19:17 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, Andrew Morton
Hi Jens,
I guessed from the oops that you might have an idea what's causing this oops
on shutdown/unmount. The git version (describe), a screenshot showing the
oops, a config, and dmesg for a booted kernel are available from:
http://devzero.co.uk/~alistair/oops-20071031/
I went back to -rc1 and it still happens there too. If you need any more
information or want me to bisect it, please let me know.
--
Cheers,
Alistair.
137/1 Warrender Park Road, Edinburgh, UK.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.24-rc1-git: crash on shutdown/unmount?
2007-10-31 19:17 2.4.24-rc1-git: crash on shutdown/unmount? Alistair John Strachan
@ 2007-10-31 19:20 ` Jens Axboe
2007-11-01 10:51 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2007-10-31 19:20 UTC (permalink / raw)
To: Alistair John Strachan; +Cc: linux-kernel, Andrew Morton
On Wed, Oct 31 2007, Alistair John Strachan wrote:
> Hi Jens,
>
> I guessed from the oops that you might have an idea what's causing this oops
> on shutdown/unmount. The git version (describe), a screenshot showing the
> oops, a config, and dmesg for a booted kernel are available from:
>
> http://devzero.co.uk/~alistair/oops-20071031/
>
> I went back to -rc1 and it still happens there too. If you need any more
> information or want me to bisect it, please let me know.
I do, I'll post a patch shortly. Just need to test it first.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.24-rc1-git: crash on shutdown/unmount?
2007-10-31 19:17 2.4.24-rc1-git: crash on shutdown/unmount? Alistair John Strachan
2007-10-31 19:20 ` Jens Axboe
@ 2007-11-01 10:51 ` Jens Axboe
[not found] ` <20071101115108.GA6615@Chamillionaire.breakpoint.cc>
2007-11-03 10:07 ` Sebastian Siewior
1 sibling, 2 replies; 6+ messages in thread
From: Jens Axboe @ 2007-11-01 10:51 UTC (permalink / raw)
To: Alistair John Strachan; +Cc: linux-kernel, Andrew Morton, lkml
On Wed, Oct 31 2007, Alistair John Strachan wrote:
> Hi Jens,
>
> I guessed from the oops that you might have an idea what's causing this oops
> on shutdown/unmount. The git version (describe), a screenshot showing the
> oops, a config, and dmesg for a booted kernel are available from:
>
> http://devzero.co.uk/~alistair/oops-20071031/
>
> I went back to -rc1 and it still happens there too. If you need any more
> information or want me to bisect it, please let me know.
Does this work for you?
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index 54fd385..75c98d5 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -3221,6 +3221,7 @@ static inline void __generic_make_request(struct bio *bio)
sector_t old_sector;
int ret, nr_sectors = bio_sectors(bio);
dev_t old_dev;
+ int err = -EIO;
might_sleep();
@@ -3248,7 +3249,7 @@ static inline void __generic_make_request(struct bio *bio)
bdevname(bio->bi_bdev, b),
(long long) bio->bi_sector);
end_io:
- bio_endio(bio, -EIO);
+ bio_endio(bio, err);
break;
}
@@ -3283,6 +3284,10 @@ end_io:
if (bio_check_eod(bio, nr_sectors))
goto end_io;
+ if (bio_empty_barrier(bio) && !q->prepare_flush_fn) {
+ err = -EOPNOTSUPP;
+ goto end_io;
+ }
ret = q->make_request_fn(q, bio);
} while (ret);
--
Jens Axboe
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: 2.4.24-rc1-git: crash on shutdown/unmount?
[not found] ` <20071101115108.GA6615@Chamillionaire.breakpoint.cc>
@ 2007-11-01 15:12 ` Alistair John Strachan
0 siblings, 0 replies; 6+ messages in thread
From: Alistair John Strachan @ 2007-11-01 15:12 UTC (permalink / raw)
To: Sebastian Siewior; +Cc: Jens Axboe, linux-kernel, Andrew Morton
On Thursday 01 November 2007 11:51:08 Sebastian Siewior wrote:
> * Jens Axboe | 2007-11-01 11:51:09 [+0100]:
> >On Wed, Oct 31 2007, Alistair John Strachan wrote:
> >> Hi Jens,
> >>
> >> I guessed from the oops that you might have an idea what's causing this
> >> oops on shutdown/unmount. The git version (describe), a screenshot
> >> showing the oops, a config, and dmesg for a booted kernel are available
> >> from:
> >>
> >> http://devzero.co.uk/~alistair/oops-20071031/
> >>
> >> I went back to -rc1 and it still happens there too. If you need any more
> >> information or want me to bisect it, please let me know.
> >
> >Does this work for you?
>
> Yes it does.
>
> Acked-by Sebastian Siewior <sebastian@breakpoint.cc>
Yep, thanks Jens. Working fine here.
Tested-by: Alistair John Strachan <alistair@devzero.co.uk>
--
Cheers,
Alistair.
137/1 Warrender Park Road, Edinburgh, UK.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.24-rc1-git: crash on shutdown/unmount?
2007-11-01 10:51 ` Jens Axboe
[not found] ` <20071101115108.GA6615@Chamillionaire.breakpoint.cc>
@ 2007-11-03 10:07 ` Sebastian Siewior
2007-11-03 16:04 ` Jens Axboe
1 sibling, 1 reply; 6+ messages in thread
From: Sebastian Siewior @ 2007-11-03 10:07 UTC (permalink / raw)
To: Jens Axboe; +Cc: Alistair John Strachan, linux-kernel, Andrew Morton
* Jens Axboe | 2007-11-01 11:51:09 [+0100]:
>On Wed, Oct 31 2007, Alistair John Strachan wrote:
>> Hi Jens,
>>
>> I guessed from the oops that you might have an idea what's causing this oops
>> on shutdown/unmount. The git version (describe), a screenshot showing the
>> oops, a config, and dmesg for a booted kernel are available from:
>>
>> http://devzero.co.uk/~alistair/oops-20071031/
>>
>> I went back to -rc1 and it still happens there too. If you need any more
>> information or want me to bisect it, please let me know.
>
>Does this work for you?
Yes, it does. Thanks for working on that. Sorry for the late reply but I
run -ENOINET.
Acked-by: Sebastian Siewior <sebastian@breakpoint.cc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.24-rc1-git: crash on shutdown/unmount?
2007-11-03 10:07 ` Sebastian Siewior
@ 2007-11-03 16:04 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2007-11-03 16:04 UTC (permalink / raw)
To: Sebastian Siewior; +Cc: Alistair John Strachan, linux-kernel, Andrew Morton
On Sat, Nov 03 2007, Sebastian Siewior wrote:
> * Jens Axboe | 2007-11-01 11:51:09 [+0100]:
>
> >On Wed, Oct 31 2007, Alistair John Strachan wrote:
> >> Hi Jens,
> >>
> >> I guessed from the oops that you might have an idea what's causing this oops
> >> on shutdown/unmount. The git version (describe), a screenshot showing the
> >> oops, a config, and dmesg for a booted kernel are available from:
> >>
> >> http://devzero.co.uk/~alistair/oops-20071031/
> >>
> >> I went back to -rc1 and it still happens there too. If you need any more
> >> information or want me to bisect it, please let me know.
> >
> >Does this work for you?
> Yes, it does. Thanks for working on that. Sorry for the late reply but I
> run -ENOINET.
>
> Acked-by: Sebastian Siewior <sebastian@breakpoint.cc>
Great, thanks to both of you for testing. When Linus pulls the stuff I
asked him to, this fix will go upstream.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-11-03 16:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-31 19:17 2.4.24-rc1-git: crash on shutdown/unmount? Alistair John Strachan
2007-10-31 19:20 ` Jens Axboe
2007-11-01 10:51 ` Jens Axboe
[not found] ` <20071101115108.GA6615@Chamillionaire.breakpoint.cc>
2007-11-01 15:12 ` Alistair John Strachan
2007-11-03 10:07 ` Sebastian Siewior
2007-11-03 16:04 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox