* [PATCH] Fix make headers_check for tipc
@ 2007-10-31 21:29 Dave Jones
2007-10-31 21:57 ` Sam Ravnborg
2007-10-31 23:16 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dave Jones @ 2007-10-31 21:29 UTC (permalink / raw)
To: Linux Kernel; +Cc: per.liden, jon.maloy, allan.stephens
make headers_check currently fails in mainline with..
include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers
There's no reason to even include this in this header as far as I can tell.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/include/linux/tipc_config.h b/include/linux/tipc_config.h
index b0c916d..83532ee 100644
--- a/include/linux/tipc_config.h
+++ b/include/linux/tipc_config.h
@@ -38,7 +38,6 @@
#define _LINUX_TIPC_CONFIG_H_
#include <linux/types.h>
-#include <linux/string.h>
#include <asm/byteorder.h>
/*
--
http://www.codemonkey.org.uk
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix make headers_check for tipc
2007-10-31 21:29 [PATCH] Fix make headers_check for tipc Dave Jones
@ 2007-10-31 21:57 ` Sam Ravnborg
2007-10-31 23:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2007-10-31 21:57 UTC (permalink / raw)
To: Dave Jones, Linux Kernel, per.liden, jon.maloy, allan.stephens
On Wed, Oct 31, 2007 at 05:29:32PM -0400, Dave Jones wrote:
> make headers_check currently fails in mainline with..
>
> include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers
>
> There's no reason to even include this in this header as far as I can tell.
The inline functions uses memcpy().
But if you just pull a fresh tree you will notice that it is fixed.
Davem did so in a rather elegant way.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix make headers_check for tipc
2007-10-31 21:29 [PATCH] Fix make headers_check for tipc Dave Jones
2007-10-31 21:57 ` Sam Ravnborg
@ 2007-10-31 23:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-31 23:16 UTC (permalink / raw)
To: davej; +Cc: linux-kernel, per.liden, jon.maloy, allan.stephens
From: Dave Jones <davej@redhat.com>
Date: Wed, 31 Oct 2007 17:29:32 -0400
> make headers_check currently fails in mainline with..
>
> include/linux/tipc_config.h requires linux/string.h, which does not exist in exported headers
>
> There's no reason to even include this in this header as far as I can tell.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
It uses memcpy() in the inline routines which are in fact used by both
userspace and the kernel. The change you are suggesting will also
break the TIPC kernel build.
A proper fix has been merged into Linus's tree already.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-31 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-31 21:29 [PATCH] Fix make headers_check for tipc Dave Jones
2007-10-31 21:57 ` Sam Ravnborg
2007-10-31 23:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox