Re: [patch 1/7] allocpercpu: Make it a true per cpu allocator by allocating from a per cpu array

Eric Dumazet
2007-11-01T07:25:42Z

Christoph Lameter a écrit :
> +
> +enum unit_type { FREE, END, USED };
> +
> +static u8 cpu_alloc_map[UNITS_PER_CPU] = { 1, };

You mean END here instead of 1 :)

> +/*
> + * Allocate an object of a certain size
> + *
> + * Returns a per cpu pointer that must not be directly used.
> + */
> +static void *cpu_alloc(unsigned long size)
> +{

We might need to give an alignment constraint here. Some per_cpu users would
like to get a 64 bytes zone, siting in one cache line and not two :)