public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] show right output for cpuinfo
@ 2007-11-01  9:56 Glauber de Oliveira Costa
  2007-11-01 14:57 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Glauber de Oliveira Costa @ 2007-11-01  9:56 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, glommer, tglx, mingo, Glauber de Oliveira Costa

in x86_64 smp systems, a regression was introduced a few days after 2.6.23,
on its way to 2.6.23. Bisection leads me to commit
92cb7612aee39642d109b8d935ad265e602c0563.

The problem is that the output of 'cat /proc/cpuinfo' shows 0 as the id of
all cpus of a smp system. As far as I know, this only happens on x86_64
systems.

This problem was first noticed by Ravikiran. A simple patch follows

Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: Ravikiran Thirumalai <kiran@scalemp.com>
---
 arch/x86/kernel/setup_64.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
index 0f0d9d4..eb41c99 100644
--- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -858,7 +858,6 @@ void __cpuinit early_identify_cpu(struct cpuinfo_x86 *c)
 
 #ifdef CONFIG_SMP
 	c->phys_proc_id = (cpuid_ebx(1) >> 24) & 0xff;
-	c->cpu_index = 0;
 #endif
 }
 
-- 
1.4.4.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] show right output for cpuinfo
  2007-11-01  9:56 [PATCH] show right output for cpuinfo Glauber de Oliveira Costa
@ 2007-11-01 14:57 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2007-11-01 14:57 UTC (permalink / raw)
  To: Glauber de Oliveira Costa; +Cc: linux-kernel, akpm, glommer, tglx


* Glauber de Oliveira Costa <gcosta@redhat.com> wrote:

> in x86_64 smp systems, a regression was introduced a few days after 
> 2.6.23, on its way to 2.6.23. Bisection leads me to commit 
> 92cb7612aee39642d109b8d935ad265e602c0563.
> 
> The problem is that the output of 'cat /proc/cpuinfo' shows 0 as the 
> id of all cpus of a smp system. As far as I know, this only happens on 
> x86_64 systems.
> 
> This problem was first noticed by Ravikiran. A simple patch follows

oops, thanks for tracking this down!

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-01 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-01  9:56 [PATCH] show right output for cpuinfo Glauber de Oliveira Costa
2007-11-01 14:57 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox