Re: [PATCH 04/27] kill filp_open()

Christoph Hellwig
2008-01-16T17:47:34Z

On Wed, Jan 16, 2008 at 09:41:12AM -0800, Dave Hansen wrote:
> On Wed, 2008-01-16 at 17:10 +0000, Christoph Hellwig wrote:
> >
> > But ultimatively I think we should remove this silly renaming from
> > the patch. It doesn't help the goal and just created churn, so please
> > rename open_namei back to do_filp_open for now and put filp_open back.
>
> It wasn't really a rename. More that I ended up moving everything
> useful the filp_open() did to other functions, so I didn't see the need
> to keep around a stub like this:
>
> struct file *filp_open(const char *filename, int flags, int mode)
> {
> return open_namei(AT_FDCWD, filename, flags, mode);
> }
>
> It would be trivial to add this stub back, though.

Well, it was a name from the caller point of view :) You basically
merged do_filp_open and open_namei. Given that open_namei was an
internal helper only used by do_filp_open it seems quite sensible to
keep the existing do_filp_open user interface and call the merged
function do_filp_open. Especially as filp_open is a quite descriptive
name of what we're doing here - open the pathname and return a file
pointer for it.