public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Latchesar Ionkov <lucho@ionkov.net>
Cc: v9fs-developer@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: basic sysfs support
Date: Fri, 2 Nov 2007 10:51:51 -0700	[thread overview]
Message-ID: <20071102175151.GA32460@kroah.com> (raw)
In-Reply-To: <20071102165331.GA16063@ionkov.net>

On Fri, Nov 02, 2007 at 10:53:31AM -0600, Latchesar Ionkov wrote:
> This patch implements the basic sysfs support for 9p. If CONFIG_NET_9P_DEBUG
> is defined, allows reading and modifying the debug level via
> /sysfs/fs/9p/debuglevel.

Since this is a debug-only type file, why not just put it in debugfs
instead?

And I have a huge patch-series pending that will make adding files like
this to sysfs much easier in the future.  But nice job, it looks like
you got it all correct, which is pretty hard to do first time these days
due to the complexity of the current interface :)

thanks,

greg k-h

  reply	other threads:[~2007-11-02 18:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 16:53 [PATCH] 9p: basic sysfs support Latchesar Ionkov
2007-11-02 17:51 ` Greg KH [this message]
2007-11-02 19:14   ` Latchesar Ionkov
2007-11-03  0:18     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071102175151.GA32460@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox