public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: delayacct regression in 2.6.24 git
Date: Sat, 3 Nov 2007 09:31:09 +0100	[thread overview]
Message-ID: <20071103083109.GD10760@elte.hu> (raw)
In-Reply-To: <472B501E.9000307@linux.vnet.ibm.com>


* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> >> Am I missing something?
> > 
> > delay accounting was causing context-switch slowdown because it 
> > called sched_clock() explicitly - but indeed my fix to that is wrong 
> > ...
> > 
> > how about reverting the change but also using rq->clock instead of 
> > sched_clock()?
> 
> Hmm... I think that might work, I find that schedule() calls 
> __update_rq_clock() which in turn calls sched_clock(), so it might be 
> a worthwhile optimization.

yep, that's the idea - in general rq->clock is updated for almost every 
scheduling event so you can rely on it instead of calling sched_clock() 
directly.

	Ingo

      reply	other threads:[~2007-11-03  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 13:41 delayacct regression in 2.6.24 git Balbir Singh
2007-11-02 15:25 ` Ingo Molnar
2007-11-02 16:28   ` Balbir Singh
2007-11-03  8:31     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071103083109.GD10760@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox