public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] replace "make ARCH=i386/x86_64 with make ARCH=x86"
Date: Sun, 4 Nov 2007 03:48:56 +0100	[thread overview]
Message-ID: <20071104024856.GK12045@stusta.de> (raw)
In-Reply-To: <472D282B.2000208@garzik.org>

On Sat, Nov 03, 2007 at 10:02:19PM -0400, Jeff Garzik wrote:
> Sam Ravnborg wrote:
>> This patchset unify the i386 and x86_64 Kconfig
>> files for x86.
>> In addition it replaces the use of ARCH=i386 and
>> ARCH=x86_64 with the more intuitive ARCH=x86.
>> The primary purpose of this patch serie is to enable make ARCH=x86 and let 
>> the config decide
>> if we are building for 32 or 64 bit.
>
> Yuck, I dislike.  Please don't take away this nice development workflow.  
> the current workflow of
>
> 	make ARCH=i386 allmodconfig && make ARCH=i386 -sj5
>
> no longer works.  Now, the new and ungainly step of editing the .config is 
> added, with vi or sed.

You could say the same about allmodconfig and 32bit on powerpc.
Or about allmodconfig and 64bit on mips.
Or about allmodconfig and little endian on mips.
Or about allmodconfig and drivers depending on !SMP on x86.
...

> This also opens a chicken-and-egg problem...  What kind of config is 
> generated by allmodconfig when ARCH==x86?  There is no good answer.

This option won't be different from all the other similar options 
allmodconfig already handles in a non-random way...

> The existing tradition of switching between 32-bit and 64-bit was quite 
> nice, and it was done in The Obvious Way(tm) -- via the method for 
> specifying the architecture/platform.  Switching to Kconfig for that 
> decision is a step backwards in usability and IMO violates the Principle of 
> Least Surprise.

The existing tradition on the powerpc and mips ports that have 32bit and 
64bit together in one directory is to switch in Kconfig, and doing it 
differently in the x86 port would violate the Principle of the Least 
Surprise.

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-11-04  2:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-03 23:48 [PATCH] replace "make ARCH=i386/x86_64 with make ARCH=x86" Sam Ravnborg
2007-11-03 23:52 ` Arjan van de Ven
2007-11-04  1:17   ` Adrian Bunk
2007-11-04  2:02 ` Jeff Garzik
2007-11-04  2:48   ` Adrian Bunk [this message]
2007-11-04  6:20   ` Jeremy Fitzhardinge
2007-11-05 10:41 ` Christoph Hellwig
2007-11-05 17:17   ` Sam Ravnborg
2007-11-05 21:36     ` Roland Dreier
2007-11-05 21:49       ` Sam Ravnborg
2007-11-05 23:46         ` H. Peter Anvin
2007-11-06  0:40           ` Guillaume Chazarain
2007-11-06  0:47             ` H. Peter Anvin
2007-11-06  1:29           ` Adrian Bunk
2007-11-06  1:33             ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071104024856.GK12045@stusta.de \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox