From: Jens Axboe <jens.axboe@oracle.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Torsten Kaiser <just.for.lkml@googlemail.com>,
linux-kernel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net
Subject: Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!
Date: Sun, 4 Nov 2007 14:26:21 +0100 [thread overview]
Message-ID: <20071104132621.GM28340@kernel.dk> (raw)
In-Reply-To: <472DC6DE.6050402@s5r6.in-berlin.de>
On Sun, Nov 04 2007, Stefan Richter wrote:
> Jens Axboe wrote:
> > Chained sg lists will only be feed to a scsi host controller that
> > enables chaining in its host template.
> >
> > The fix looks fine though, it's just not a requirement or bug fix :-)
>
> Good, then the sbp2 and fw-sbp2 patches can wait for 2.6.25.
>
> Which criteria decide whether a SCSI low-level driver should enable
> chained s/g lists? The SBP-2 protocol supports s/g lists with up to
> 65535 entries. The sbp2 and fw-sbp2 driver limit this currently to SG_ALL.
If the driver can benefit (or even requires) from more segments than you
can typically allocate in one piece, then it should enable chaining. In
general, all drivers must be transitioned to using the sg accessor
helpers, so we can eventually kill the sg chaining enable parameter in
the host template and just make it the default. The parameter is only
there as a transition help.
--
Jens Axboe
next prev parent reply other threads:[~2007-11-04 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 22:03 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49! Torsten Kaiser
2007-11-02 22:32 ` Stefan Richter
2007-11-02 23:16 ` Stefan Richter
2007-11-03 7:03 ` Jens Axboe
2007-11-03 13:14 ` Torsten Kaiser
2007-11-03 14:42 ` Stefan Richter
2007-11-03 16:04 ` Jens Axboe
2007-11-04 8:44 ` Jens Axboe
2007-11-04 10:51 ` Torsten Kaiser
2007-11-04 12:08 ` [PATCH 1/3 2.6.24-rc1-gitX] ieee1394: iso and async streams: s/g list fix Stefan Richter
2007-11-04 12:09 ` [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: " Stefan Richter
2007-11-04 12:10 ` [PATCH 3/3 2.6.24-rc1-gitX] firewire: fw-sbp2: " Stefan Richter
2007-11-04 12:27 ` [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: " Stefan Richter
2007-11-04 13:03 ` 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49! Jens Axboe
2007-11-04 13:19 ` Stefan Richter
2007-11-04 13:26 ` Jens Axboe [this message]
[not found] ` <tkrat.4947ae1f5baa964f@s5r6.in-berlin.de>
[not found] ` <tkrat.2a470664250af864@s5r6.in-berlin.de>
[not found] ` <tkrat.29809d64b9426d9a@s5r6.in-berlin.de>
2008-02-01 21:31 ` [PATCH] ieee1394: sbp2: fix bogus s/g access change Stefan Richter
2007-11-04 14:53 ` 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49! Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071104132621.GM28340@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox