* [PATCH] 82596: free nonexistent resource fix
@ 2007-11-04 20:22 Evgeniy Dushistov
0 siblings, 0 replies; only message in thread
From: Evgeniy Dushistov @ 2007-11-04 20:22 UTC (permalink / raw)
To: Andrew Morton, Jeff Garzik; +Cc: linux-kernel
During booting of last vanilla kernel I got:
Trying to free nonexistent resource...
This because of if "ENABLE_APRICOT" is on we do:
request_region(ioaddr,...)
if (checksum test failed)
goto out1;
dev->base_addr = ioaddr;//<-here mistake
out1:
release_region(dev->base_addr,...)
Here patch which fixes this bug for me.
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
---
diff --git a/drivers/net/82596.c b/drivers/net/82596.c
index bb30d5b..2797da7 100644
--- a/drivers/net/82596.c
+++ b/drivers/net/82596.c
@@ -1192,6 +1192,8 @@ struct net_device * __init i82596_probe(int unit)
goto out;
}
+ dev->base_addr = ioaddr;
+
for (i = 0; i < 8; i++) {
eth_addr[i] = inb(ioaddr + 8 + i);
checksum += eth_addr[i];
@@ -1209,7 +1211,6 @@ struct net_device * __init i82596_probe(int unit)
goto out1;
}
- dev->base_addr = ioaddr;
dev->irq = 10;
}
#endif
--
/Evgeniy
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-04 21:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-04 20:22 [PATCH] 82596: free nonexistent resource fix Evgeniy Dushistov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox