public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [git Patch] Makefile: Remove ncscope.out when make mrproper
Date: Mon, 5 Nov 2007 08:41:37 +0100	[thread overview]
Message-ID: <20071105074137.GA26540@uranus.ravnborg.org> (raw)
In-Reply-To: <20071105073233.GC2461@hacking>

On Mon, Nov 05, 2007 at 03:32:33PM +0800, WANG Cong wrote:
> 
> Hi, Sam!
> 
> This patch adds the ncscope.out file into cleaning targets of 'make mrproper'.
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/Makefile
> ===================================================================
> --- linux-2.6.orig/Makefile
> +++ linux-2.6/Makefile
> @@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
>  MRPROPER_FILES += .config .config.old include/asm .version .old_version \
>                    include/linux/autoconf.h include/linux/version.h      \
>                    include/linux/utsrelease.h                            \
> -		  Module.symvers tags TAGS cscope*
> +		  Module.symvers tags TAGS cscope* ncscope.out

Hi WANG.

ncscope.out is just a temporary file but I see why you like to have it covered.
How about modifying the rule to look like this:
> -		  Module.symvers tags TAGS cscope*
> +		  Module.symvers tags TAGS *cscope*

Or is this to broad a pattern?

	Sam

  reply	other threads:[~2007-11-05  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05  7:32 [git Patch] Makefile: Remove ncscope.out when make mrproper WANG Cong
2007-11-05  7:41 ` Sam Ravnborg [this message]
2007-11-05  8:11   ` WANG Cong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071105074137.GA26540@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox