From: Jens Axboe <jens.axboe@oracle.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick <gentuu@gmail.com>, Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting
Date: Mon, 5 Nov 2007 08:57:33 +0100 [thread overview]
Message-ID: <20071105075732.GA5359@kernel.dk> (raw)
In-Reply-To: <20071104193221.GA12373@tv-sign.ru>
On Sun, Nov 04 2007, Oleg Nesterov wrote:
> (untested, needs an ack from maintainer)
>
> Spotted by Nick <gentuu@gmail.com>, hopefully can explain the second trace in
> http://bugzilla.kernel.org/show_bug.cgi?id=9180.
>
> If ->async_idle_cfqq != NULL cfq_put_async_queues() puts it IOPRIO_BE_NR times
> in a loop. Fix this.
That's obviously buggy, thanks Oleg! Fix is indeed correct. I'll add it.
--
Jens Axboe
prev parent reply other threads:[~2007-11-05 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 19:32 [PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting Oleg Nesterov
2007-11-05 7:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105075732.GA5359@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=gentuu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox