public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [git Patch] Makefile: Remove ncscope.out when make mrproper
@ 2007-11-05  7:32 WANG Cong
  2007-11-05  7:41 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: WANG Cong @ 2007-11-05  7:32 UTC (permalink / raw)
  To: LKML; +Cc: Sam Ravnborg, linux-kbuild, Andrew Morton


Hi, Sam!

This patch adds the ncscope.out file into cleaning targets of 'make mrproper'.

Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>

---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/Makefile
===================================================================
--- linux-2.6.orig/Makefile
+++ linux-2.6/Makefile
@@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS cscope* ncscope.out
 
 # clean - Delete most, but leave enough to build external modules
 #

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [git Patch] Makefile: Remove ncscope.out when make mrproper
  2007-11-05  7:32 [git Patch] Makefile: Remove ncscope.out when make mrproper WANG Cong
@ 2007-11-05  7:41 ` Sam Ravnborg
  2007-11-05  8:11   ` WANG Cong
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2007-11-05  7:41 UTC (permalink / raw)
  To: WANG Cong; +Cc: LKML, linux-kbuild, Andrew Morton

On Mon, Nov 05, 2007 at 03:32:33PM +0800, WANG Cong wrote:
> 
> Hi, Sam!
> 
> This patch adds the ncscope.out file into cleaning targets of 'make mrproper'.
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/Makefile
> ===================================================================
> --- linux-2.6.orig/Makefile
> +++ linux-2.6/Makefile
> @@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
>  MRPROPER_FILES += .config .config.old include/asm .version .old_version \
>                    include/linux/autoconf.h include/linux/version.h      \
>                    include/linux/utsrelease.h                            \
> -		  Module.symvers tags TAGS cscope*
> +		  Module.symvers tags TAGS cscope* ncscope.out

Hi WANG.

ncscope.out is just a temporary file but I see why you like to have it covered.
How about modifying the rule to look like this:
> -		  Module.symvers tags TAGS cscope*
> +		  Module.symvers tags TAGS *cscope*

Or is this to broad a pattern?

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [git Patch] Makefile: Remove ncscope.out when make mrproper
  2007-11-05  7:41 ` Sam Ravnborg
@ 2007-11-05  8:11   ` WANG Cong
  0 siblings, 0 replies; 3+ messages in thread
From: WANG Cong @ 2007-11-05  8:11 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: WANG Cong, LKML, linux-kbuild, Andrew Morton

On Mon, Nov 05, 2007 at 08:41:37AM +0100, Sam Ravnborg wrote:

<snip>

>
>Hi WANG.
>
>ncscope.out is just a temporary file but I see why you like to have it covered.

Thanks. ;)

>How about modifying the rule to look like this:
>> -		  Module.symvers tags TAGS cscope*
>> +		  Module.symvers tags TAGS *cscope*
>
>Or is this to broad a pattern?
>
>	Sam

Yes, that is better. New patch below.


Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

---
Index: linux-2.6/Makefile
===================================================================
--- linux-2.6.orig/Makefile
+++ linux-2.6/Makefile
@@ -1073,7 +1073,7 @@ MRPROPER_DIRS  += include/config include
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS *cscope*
 
 # clean - Delete most, but leave enough to build external modules
 #

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-11-05  8:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-05  7:32 [git Patch] Makefile: Remove ncscope.out when make mrproper WANG Cong
2007-11-05  7:41 ` Sam Ravnborg
2007-11-05  8:11   ` WANG Cong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox