From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mikael Starvik <mikael.starvik@axis.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CRIS v10 serial driver rewrite take two
Date: Mon, 5 Nov 2007 14:56:21 +0100 [thread overview]
Message-ID: <20071105135621.GM7621@axis.com> (raw)
In-Reply-To: <472F1E7B.8060304@gmail.com>
On Mon, Nov 05, 2007 at 02:45:31PM +0100, Jiri Slaby wrote:
> On 11/05/2007 02:11 PM, Jesper Nilsson wrote:
> > if (tty_hung_up_p(filp) ||
> > (info->flags & ASYNC_CLOSING)) {
> > if (info->flags & ASYNC_CLOSING)
>
> You can remove this (__^) line now, the test itself is inside
> wait_event_interruptible macro yet.
Ah, yes, so it is.
> > - interruptible_sleep_on(&info->close_wait);
> > + wait_event_interruptible(info->close_wait,
> > + !info->flags & ASYNC_CLOSING);
>
> This is still buggy, I intentionally put the parenthesis around "info->flags &
> ASYNC_CLOSING" in my previous mail. This way it will ever evaluate to 0 (since
> it is as same as (!info->flags) & ASYNC_CLOSING now).
Of course. I thought about it, but obviously my brain used teflon-coated
memory to store that information. I'll be back with yet another version.
> Jiri Slaby (jirislaby@gmail.com)
Thanks again for you comments,
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2007-11-05 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 13:11 [PATCH] CRIS v10 serial driver rewrite take two Jesper Nilsson
2007-11-05 13:45 ` Jiri Slaby
2007-11-05 13:56 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105135621.GM7621@axis.com \
--to=jesper.nilsson@axis.com \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox