* [2.6 patch] power_supply_{leds,sysfs}.c should #include "power_supply.h"
@ 2007-11-05 17:07 Adrian Bunk
2007-11-25 23:19 ` Anton Vorontsov
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-11-05 17:07 UTC (permalink / raw)
To: linux-kernel
Every file should include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/power/power_supply_leds.c | 2 ++
drivers/power/power_supply_sysfs.c | 2 ++
2 files changed, 4 insertions(+)
e34cc994731ec9102bf5b1c7d6585c0aa87d1fa2
diff --git a/drivers/power/power_supply_leds.c b/drivers/power/power_supply_leds.c
index 7f8f359..80ca288 100644
--- a/drivers/power/power_supply_leds.c
+++ b/drivers/power/power_supply_leds.c
@@ -12,6 +12,8 @@
#include <linux/power_supply.h>
+#include "power_supply.h"
+
/* Battery specific LEDs triggers. */
static void power_supply_update_bat_leds(struct power_supply *psy)
diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 249f61b..e8ad1fd 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -14,6 +14,8 @@
#include <linux/ctype.h>
#include <linux/power_supply.h>
+#include "power_supply.h"
+
/*
* This is because the name "current" breaks the device attr macro.
* The "current" word resolves to "(get_current())" so instead of
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] power_supply_{leds,sysfs}.c should #include "power_supply.h"
2007-11-05 17:07 [2.6 patch] power_supply_{leds,sysfs}.c should #include "power_supply.h" Adrian Bunk
@ 2007-11-25 23:19 ` Anton Vorontsov
0 siblings, 0 replies; 2+ messages in thread
From: Anton Vorontsov @ 2007-11-25 23:19 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Mon, Nov 05, 2007 at 06:07:45PM +0100, Adrian Bunk wrote:
> Every file should include the headers containing the prototypes for
> its global functions.
Applied to battery-2.6.git, thanks.
p.s.
Sorry for the delay, I've not been Cc'ed, so I've found out about
that patch by pure chance (through looking in the -mm series).
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/power/power_supply_leds.c | 2 ++
> drivers/power/power_supply_sysfs.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> e34cc994731ec9102bf5b1c7d6585c0aa87d1fa2
> diff --git a/drivers/power/power_supply_leds.c b/drivers/power/power_supply_leds.c
> index 7f8f359..80ca288 100644
> --- a/drivers/power/power_supply_leds.c
> +++ b/drivers/power/power_supply_leds.c
> @@ -12,6 +12,8 @@
>
> #include <linux/power_supply.h>
>
> +#include "power_supply.h"
> +
> /* Battery specific LEDs triggers. */
>
> static void power_supply_update_bat_leds(struct power_supply *psy)
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 249f61b..e8ad1fd 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -14,6 +14,8 @@
> #include <linux/ctype.h>
> #include <linux/power_supply.h>
>
> +#include "power_supply.h"
> +
> /*
> * This is because the name "current" breaks the device attr macro.
> * The "current" word resolves to "(get_current())" so instead of
>
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-25 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-05 17:07 [2.6 patch] power_supply_{leds,sysfs}.c should #include "power_supply.h" Adrian Bunk
2007-11-25 23:19 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox