* [PATCH 4/6] UML - Console driver cleanups
@ 2007-11-05 19:27 Jeff Dike
0 siblings, 0 replies; only message in thread
From: Jeff Dike @ 2007-11-05 19:27 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, uml-devel
Console driver cleanups -
Changed an instance of foo = bar + foo to foo += bar
Removed checks of tty->stopped - I don't think the low-level
driver has any business looking at that
Removed an annoying warning
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
arch/um/drivers/line.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
Index: linux-2.6/arch/um/drivers/line.c
===================================================================
--- linux-2.6.orig/arch/um/drivers/line.c 2007-11-05 14:06:09.000000000 -0500
+++ linux-2.6/arch/um/drivers/line.c 2007-11-05 14:13:24.000000000 -0500
@@ -48,7 +48,7 @@ static int write_room(struct line *line)
n = line->head - line->tail;
if (n <= 0)
- n = LINE_BUFSIZE + n; /* The other case */
+ n += LINE_BUFSIZE; /* The other case */
return n - 1;
}
@@ -58,17 +58,10 @@ int line_write_room(struct tty_struct *t
unsigned long flags;
int room;
- if (tty->stopped)
- return 0;
-
spin_lock_irqsave(&line->lock, flags);
room = write_room(line);
spin_unlock_irqrestore(&line->lock, flags);
- /*XXX: Warning to remove */
- if (0 == room)
- printk(KERN_DEBUG "%s: %s: no room left in buffer\n",
- __FUNCTION__,tty->name);
return room;
}
@@ -79,8 +72,7 @@ int line_chars_in_buffer(struct tty_stru
int ret;
spin_lock_irqsave(&line->lock, flags);
-
- /*write_room subtracts 1 for the needed NULL, so we readd it.*/
+ /* write_room subtracts 1 for the needed NULL, so we readd it.*/
ret = LINE_BUFSIZE - (write_room(line) + 1);
spin_unlock_irqrestore(&line->lock, flags);
@@ -184,10 +176,6 @@ void line_flush_buffer(struct tty_struct
unsigned long flags;
int err;
- /*XXX: copied from line_write, verify if it is correct!*/
- if (tty->stopped)
- return;
-
spin_lock_irqsave(&line->lock, flags);
err = flush_buffer(line);
spin_unlock_irqrestore(&line->lock, flags);
@@ -213,9 +201,6 @@ int line_write(struct tty_struct *tty, c
unsigned long flags;
int n, ret = 0;
- if (tty->stopped)
- return 0;
-
spin_lock_irqsave(&line->lock, flags);
if (line->head != line->tail)
ret = buffer_data(line, buf, len);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-05 19:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-05 19:27 [PATCH 4/6] UML - Console driver cleanups Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox