Re: mm snapshot broken-out-2007-11-06-02-32 - powerpc link failure

Badari Pulavarty
2007-11-06T18:59:31Z

On Tue, 2007-11-06 at 23:47 +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel linking fails on the powerpc, with following error message
>
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> arch/powerpc/kernel/built-in.o(.toc+0x1550): undefined reference to `devices_subsys'
> make: *** [.tmp_vmlinux1] Error 1

I sent a fix for this 30 minutes ago ..

Here it is anyway.

Thanks,
Badari

---
arch/powerpc/kernel/vio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.24-rc1/arch/powerpc/kernel/vio.c
===================================================================
--- linux-2.6.24-rc1.orig/arch/powerpc/kernel/vio.c 2007-10-23 20:50:57.000000000 -0700
+++ linux-2.6.24-rc1/arch/powerpc/kernel/vio.c 2007-11-06 10:31:56.000000000 -0800
@@ -37,7 +37,7 @@
#include <asm/iseries/hv_call_xm.h>
#include <asm/iseries/iommu.h>

-extern struct kset devices_subsys; /* needed for vio_find_name() */
+extern struct kset *devices_kset; /* needed for vio_find_name() */

static struct bus_type vio_bus_type;

@@ -369,7 +369,7 @@ static struct vio_dev *vio_find_name(con
{
struct kobject *found;

- found = kset_find_obj(&devices_subsys, kobj_name);
+ found = kset_find_obj(devices_kset, kobj_name);
if (!found)
return NULL;