UML defconfig building failed again

UML defconfig building failed again

[WANG Cong]

Hi, Jeff!

I used today's linus-tree and defconfig to compile uml, but it failed. Error messages are
things like:

In file included from include/asm/processor-generic.h:13,
                 from include/asm/processor.h:77,
                 from include/asm/thread_info.h:11,
                 from include/linux/thread_info.h:21,
                 from include/linux/preempt.h:9,
                 from include/linux/spinlock.h:49,
                 from include/linux/seqlock.h:29,
                 from include/linux/time.h:8,
                 from include/linux/timex.h:57,
                 from include/linux/sched.h:53,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/asm/ptrace.h:50: warning: ‘struct user_fxsr_struct’ declared inside parameter list
include/asm/ptrace.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
include/asm/ptrace.h:52: warning: ‘struct user_fxsr_struct’ declared inside parameter list
In file included from include/linux/timer.h:5,
                 from include/linux/sched.h:87,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/linux/ktime.h: In function ‘ktime_set’:
include/linux/ktime.h:84: warning: comparison is always false due to limited range of data type

{snip}

It seems like CONFIG_X86_32 was not set. Any ideas?

Thanks.

Re: UML defconfig building failed again

[Al Viro]

On Tue, Nov 06, 2007 at 07:46:02PM +0800, WANG Cong wrote:
> 
> Hi, Jeff!
> 
> I used today's linus-tree and defconfig to compile uml, but it failed. Error messages are
> things like:
> 
> In file included from include/asm/processor-generic.h:13,
>                  from include/asm/processor.h:77,
>                  from include/asm/thread_info.h:11,
>                  from include/linux/thread_info.h:21,
>                  from include/linux/preempt.h:9,
>                  from include/linux/spinlock.h:49,
>                  from include/linux/seqlock.h:29,
>                  from include/linux/time.h:8,
>                  from include/linux/timex.h:57,
>                  from include/linux/sched.h:53,
>                  from arch/um/include/sysdep/kernel-offsets.h:2,
>                  from arch/um/kernel/asm-offsets.c:1:
> include/asm/ptrace.h:50: warning: ???struct user_fxsr_struct??? declared inside parameter list
> include/asm/ptrace.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
> include/asm/ptrace.h:52: warning: ???struct user_fxsr_struct??? declared inside parameter list
> In file included from include/linux/timer.h:5,
>                  from include/linux/sched.h:87,
>                  from arch/um/include/sysdep/kernel-offsets.h:2,
>                  from arch/um/kernel/asm-offsets.c:1:
> include/linux/ktime.h: In function ???ktime_set???:
> include/linux/ktime.h:84: warning: comparison is always false due to limited range of data type
> 
> {snip}
> 
> It seems like CONFIG_X86_32 was not set. Any ideas?

Sigh...  Kbuild breakage this time...  See if %s/\<[AC]FLAGS\>/KBUILD_&/g
in arch/um/Makefile-i386 helps.

Re: UML defconfig building failed again

[Jeff Dike]

On Tue, Nov 06, 2007 at 02:11:43PM +0000, Al Viro wrote:
> Sigh...  Kbuild breakage this time...  See if %s/\<[AC]FLAGS\>/KBUILD_&/g
> in arch/um/Makefile-i386 helps.

Yup, this fixes it:


     [AC]FLAGS -> KBUILD_[AC]FLAGS conversion in Makefile-i386.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
 arch/um/Makefile-i386 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/um/Makefile-i386 b/arch/um/Makefile-i386
index b01dfb0..6729011 100644
--- a/arch/um/Makefile-i386
+++ b/arch/um/Makefile-i386
@@ -22,8 +22,8 @@ export LDFLAGS HOSTCFLAGS HOSTLDFLAGS UML_OBJCOPYFLAGS
 endif
 endif
 
-CFLAGS			+= -DCONFIG_X86_32
-AFLAGS			+= -DCONFIG_X86_32
+KBUILD_CFLAGS		+= -DCONFIG_X86_32
+KBUILD_AFLAGS		+= -DCONFIG_X86_32
 CONFIG_X86_32		:= y
 export CONFIG_X86_32

Re: UML defconfig building failed again

[Sam Ravnborg]

On Tue, Nov 06, 2007 at 02:11:43PM +0000, Al Viro wrote:
> On Tue, Nov 06, 2007 at 07:46:02PM +0800, WANG Cong wrote:
> > 
> > Hi, Jeff!
> > 
> > I used today's linus-tree and defconfig to compile uml, but it failed. Error messages are
> > things like:
> > 
> > In file included from include/asm/processor-generic.h:13,
> >                  from include/asm/processor.h:77,
> >                  from include/asm/thread_info.h:11,
> >                  from include/linux/thread_info.h:21,
> >                  from include/linux/preempt.h:9,
> >                  from include/linux/spinlock.h:49,
> >                  from include/linux/seqlock.h:29,
> >                  from include/linux/time.h:8,
> >                  from include/linux/timex.h:57,
> >                  from include/linux/sched.h:53,
> >                  from arch/um/include/sysdep/kernel-offsets.h:2,
> >                  from arch/um/kernel/asm-offsets.c:1:
> > include/asm/ptrace.h:50: warning: ???struct user_fxsr_struct??? declared inside parameter list
> > include/asm/ptrace.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
> > include/asm/ptrace.h:52: warning: ???struct user_fxsr_struct??? declared inside parameter list
> > In file included from include/linux/timer.h:5,
> >                  from include/linux/sched.h:87,
> >                  from arch/um/include/sysdep/kernel-offsets.h:2,
> >                  from arch/um/kernel/asm-offsets.c:1:
> > include/linux/ktime.h: In function ???ktime_set???:
> > include/linux/ktime.h:84: warning: comparison is always false due to limited range of data type
> > 
> > {snip}
> > 
> > It seems like CONFIG_X86_32 was not set. Any ideas?
> 
> Sigh...  Kbuild breakage this time...  See if %s/\<[AC]FLAGS\>/KBUILD_&/g
> in arch/um/Makefile-i386 helps.
Ups - my bad.
I have somehow overlooked those two assignments in the middle.

	Sam