From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
wei.zhang@freescale.com, ebony.zhu@freescale.com,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - Build Failure at fsldma.c
Date: Tue, 6 Nov 2007 20:21:19 +0530 [thread overview]
Message-ID: <20071106145119.GA32391@linux.vnet.ibm.com> (raw)
Hi Andrew,
The build fails with error
CC net/9p/error.o
drivers/dma/fsldma.h:152: error: conflicting types for ‘in_be64’
include/asm/io.h:136: error: previous definition of ‘in_be64’ was here
drivers/dma/fsldma.h:157: error: conflicting types for ‘out_be64’
include/asm/io.h:135: error: previous definition of ‘out_be64’ was here
drivers/dma/fsldma.h:164: error: conflicting types for ‘in_le64’
include/asm/io.h:140: error: previous definition of ‘in_le64’ was here
drivers/dma/fsldma.h:169: error: conflicting types for ‘out_le64’
include/asm/io.h:145: error: previous definition of ‘out_le64’ was here
drivers/dma/fsldma.c:504: error: implicit declaration of function ‘bus_to_virt’
make[2]: *** [drivers/dma/fsldma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2
This error is caused by the patch add-dma-engine-driver-for-freescale-mpc85xx-processors.patch
The following patch solves the conflict types error, but the bus_to_virt
is under the CONFIG_PPC32 ifdef and we had a discuss on the same for the
availability of the function for ppc64 at http://lkml.org/lkml/2007/10/17/524
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.24-rc1/drivers/dma/fsldma.h 2007-11-06 09:12:09.000000000 -0500
+++ linux-2.6.24-rc1/drivers/dma/~fsldma.h 2007-11-06 09:12:31.000000000 -0500
@@ -147,7 +147,7 @@ struct fsl_dma_chan {
#define to_fsl_desc(lh) container_of(lh, struct fsl_desc_sw, node)
#define tx_to_fsl_desc(tx) container_of(tx, struct fsl_desc_sw, async_tx)
-#ifndef __powerpc64
+#ifndef __powerpc64__
static u64 in_be64(const u64 __iomem *addr)
{
return ((u64)in_be32((u32 *)addr) << 32) | (in_be32((u32 *)addr + 1));
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
reply other threads:[~2007-11-06 14:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106145119.GA32391@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=ebony.zhu@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=wei.zhang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox