public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Herrmann" <andreas.herrmann3@amd.com>
To: "Zou Nan hai" <nanhai.zou@intel.com>
Cc: "LKML" <linux-kernel@vger.kernel.org>, "Andrew Morton" <akpm@osdl.org>
Subject: Re: [Patch2/2] fix wrong proc cpuinfo on x64
Date: Tue, 6 Nov 2007 19:37:10 +0100	[thread overview]
Message-ID: <20071106183710.GD15369@alberich.amd.com> (raw)
In-Reply-To: <1194333940.3046.38.camel@linux-znh>

On Tue, Nov 06, 2007 at 04:28:20PM +0800, Zou Nan hai wrote:
> in 2.6.24-rc1 kernel, 
> The /proc/cpuinfo display is wrong.
> 
> Another issue is that it will display bogus cpus with wrong information
> if the kernel is compiled with a big CONFIG_NR_CPU.
> 
> That is because before a cpu in cpu_present_map is up, c->cpu_index of
> that cpu is 0.
> thus the cpu_online(c->cpu_index) check in show_cpuinfo is invalid.

This issue should already be fixed with that patch

http://marc.info/?l=linux-kernel&m=119394201230954

> This patch will let cpuinfo_op use cpu_online_map instead of
> cpu_present_map to iterate cpus.

BTW, the problem affects i386 as well.


Regards,

Andreas

-- 
Operating | AMD Saxony Limited Liability Company & Co. KG,
  System  | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 Research | Register Court Dresden: HRA 4896, General Partner authorized
  Center  | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
  (OSRC)  | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy




      reply	other threads:[~2007-11-06 18:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06  8:28 [Patch2/2] fix wrong proc cpuinfo on x64 Zou Nan hai
2007-11-06 18:37 ` Andreas Herrmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071106183710.GD15369@alberich.amd.com \
    --to=andreas.herrmann3@amd.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nanhai.zou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox