From: "Andreas Herrmann" <andreas.herrmann3@amd.com>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
gcosta@redhat.com, mingo@elte.hu, tglx@linutronix.de,
travis@sgi.com
Subject: Re: + x86-show-cpuinfo-only-for-online-cpus.patch added to -mm tree
Date: Tue, 6 Nov 2007 20:20:54 +0100 [thread overview]
Message-ID: <20071106192026.GE15369@alberich.amd.com> (raw)
In-Reply-To: <86802c440711011531u5a8a4872r3b4c33e5fd0fd0c9@mail.gmail.com>
On Thu, Nov 01, 2007 at 03:31:23PM -0700, Yinghai Lu wrote:
>
> wonder if could change
>
> > if (!cpu_online(c->cpu_index))
> > return 0;
>
> ==>
>
> > if (c->cpu_index >= NR_CPUS)
> > return 0;
>
> and add another entry for every cpu
> online : 1 when it is enabled
> or online : 0 when it is disabled by /sys/devices/system/cpuX/online.
No, I don't think that would be a good idea. It would change
the usual behaviour of that interface (to display only CPUs that
are "up and running".)
Regards,
Andreas
--
Operating | AMD Saxony Limited Liability Company & Co. KG,
System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Research | Register Court Dresden: HRA 4896, General Partner authorized
Center | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
(OSRC) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
prev parent reply other threads:[~2007-11-06 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071101193932.8A44D432BDC@localhost>
2007-11-01 22:31 ` + x86-show-cpuinfo-only-for-online-cpus.patch added to -mm tree Yinghai Lu
2007-11-06 19:20 ` Andreas Herrmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106192026.GE15369@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox