public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-mm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Cc: Eric Dumazet <dada1@cosmosbay.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 10/28] cpu alloc: workqueue conversion
Date: Tue, 06 Nov 2007 11:51:54 -0800	[thread overview]
Message-ID: <20071106195159.940836114@sgi.com> (raw)
In-Reply-To: 20071106195144.983665861@sgi.com

[-- Attachment #1: cpu_alloc_workqueue --]
[-- Type: text/plain, Size: 3629 bytes --]

Signed-off-by: Christoph Lameter <clameter@sgi.com>


---
 kernel/workqueue.c |   28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

Index: linux-2.6/kernel/workqueue.c
===================================================================
--- linux-2.6.orig/kernel/workqueue.c	2007-11-04 13:10:18.000000000 -0800
+++ linux-2.6/kernel/workqueue.c	2007-11-04 13:14:22.000000000 -0800
@@ -33,6 +33,7 @@
 #include <linux/kallsyms.h>
 #include <linux/debug_locks.h>
 #include <linux/lockdep.h>
+#include <linux/cpu_alloc.h>
 
 /*
  * The per-CPU workqueue (if single thread, we always use the first
@@ -100,7 +101,7 @@ struct cpu_workqueue_struct *wq_per_cpu(
 {
 	if (unlikely(is_single_threaded(wq)))
 		cpu = singlethread_cpu;
-	return per_cpu_ptr(wq->cpu_wq, cpu);
+	return CPU_PTR(wq->cpu_wq, cpu);
 }
 
 /*
@@ -398,7 +399,7 @@ void fastcall flush_workqueue(struct wor
 	lock_acquire(&wq->lockdep_map, 0, 0, 0, 2, _THIS_IP_);
 	lock_release(&wq->lockdep_map, 1, _THIS_IP_);
 	for_each_cpu_mask(cpu, *cpu_map)
-		flush_cpu_workqueue(per_cpu_ptr(wq->cpu_wq, cpu));
+		flush_cpu_workqueue(CPU_PTR(wq->cpu_wq, cpu));
 }
 EXPORT_SYMBOL_GPL(flush_workqueue);
 
@@ -478,7 +479,7 @@ static void wait_on_work(struct work_str
 	cpu_map = wq_cpu_map(wq);
 
 	for_each_cpu_mask(cpu, *cpu_map)
-		wait_on_cpu_work(per_cpu_ptr(wq->cpu_wq, cpu), work);
+		wait_on_cpu_work(CPU_PTR(wq->cpu_wq, cpu), work);
 }
 
 static int __cancel_work_timer(struct work_struct *work,
@@ -601,21 +602,21 @@ int schedule_on_each_cpu(work_func_t fun
 	int cpu;
 	struct work_struct *works;
 
-	works = alloc_percpu(struct work_struct);
+	works = CPU_ALLOC(struct work_struct, GFP_KERNEL);
 	if (!works)
 		return -ENOMEM;
 
 	preempt_disable();		/* CPU hotplug */
 	for_each_online_cpu(cpu) {
-		struct work_struct *work = per_cpu_ptr(works, cpu);
+		struct work_struct *work = CPU_PTR(works, cpu);
 
 		INIT_WORK(work, func);
 		set_bit(WORK_STRUCT_PENDING, work_data_bits(work));
-		__queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), work);
+		__queue_work(CPU_PTR(keventd_wq->cpu_wq, cpu), work);
 	}
 	preempt_enable();
 	flush_workqueue(keventd_wq);
-	free_percpu(works);
+	CPU_FREE(works);
 	return 0;
 }
 
@@ -664,7 +665,7 @@ int current_is_keventd(void)
 
 	BUG_ON(!keventd_wq);
 
-	cwq = per_cpu_ptr(keventd_wq->cpu_wq, cpu);
+	cwq = CPU_PTR(keventd_wq->cpu_wq, cpu);
 	if (current == cwq->thread)
 		ret = 1;
 
@@ -675,7 +676,7 @@ int current_is_keventd(void)
 static struct cpu_workqueue_struct *
 init_cpu_workqueue(struct workqueue_struct *wq, int cpu)
 {
-	struct cpu_workqueue_struct *cwq = per_cpu_ptr(wq->cpu_wq, cpu);
+	struct cpu_workqueue_struct *cwq = CPU_PTR(wq->cpu_wq, cpu);
 
 	cwq->wq = wq;
 	spin_lock_init(&cwq->lock);
@@ -732,7 +733,8 @@ struct workqueue_struct *__create_workqu
 	if (!wq)
 		return NULL;
 
-	wq->cpu_wq = alloc_percpu(struct cpu_workqueue_struct);
+	wq->cpu_wq = CPU_ALLOC(struct cpu_workqueue_struct,
+					GFP_KERNEL|__GFP_ZERO);
 	if (!wq->cpu_wq) {
 		kfree(wq);
 		return NULL;
@@ -814,11 +816,11 @@ void destroy_workqueue(struct workqueue_
 	mutex_unlock(&workqueue_mutex);
 
 	for_each_cpu_mask(cpu, *cpu_map) {
-		cwq = per_cpu_ptr(wq->cpu_wq, cpu);
+		cwq = CPU_PTR(wq->cpu_wq, cpu);
 		cleanup_workqueue_thread(cwq, cpu);
 	}
 
-	free_percpu(wq->cpu_wq);
+	CPU_FREE(wq->cpu_wq);
 	kfree(wq);
 }
 EXPORT_SYMBOL_GPL(destroy_workqueue);
@@ -847,7 +849,7 @@ static int __devinit workqueue_cpu_callb
 	}
 
 	list_for_each_entry(wq, &workqueues, list) {
-		cwq = per_cpu_ptr(wq->cpu_wq, cpu);
+		cwq = CPU_PTR(wq->cpu_wq, cpu);
 
 		switch (action) {
 		case CPU_UP_PREPARE:

-- 

  parent reply	other threads:[~2007-11-06 20:01 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06 19:51 [patch 00/28] cpu alloc v1: Optimize by removing arrays of pointers to per cpu objects Christoph Lameter
2007-11-06 19:51 ` [patch 01/28] cpu alloc: The allocator Christoph Lameter
2007-11-08 12:34   ` Peter Zijlstra
2007-11-08 12:37     ` Peter Zijlstra
2007-11-08 18:33     ` Christoph Lameter
2007-11-08 18:50       ` Christoph Lameter
2007-11-08 20:19         ` Peter Zijlstra
     [not found]   ` <1194522615.6289.136.camel@twins>
     [not found]     ` <Pine.LNX.4.64.0711081030380.7871@schroedinger.engr.sgi.com>
2007-11-08 20:19       ` Peter Zijlstra
2007-11-08 20:24         ` Christoph Lameter
2007-11-08 23:26           ` David Miller
2007-11-08 23:26         ` David Miller
2007-11-13 11:15   ` David Miller
2007-11-13 21:40     ` Christoph Lameter
2007-11-13 21:58       ` Eric Dumazet
2007-11-13 22:00         ` Christoph Lameter
2007-11-14  1:33           ` David Miller
2007-11-13 22:02         ` Christoph Lameter
2007-11-14  1:30       ` David Miller
2007-11-14  1:48         ` Christoph Lameter
2007-11-13 22:20     ` Christoph Lameter
2007-11-14  1:36       ` David Miller
2007-11-14  1:37       ` David Miller
2007-11-14  1:50         ` Christoph Lameter
2007-11-14  2:00           ` David Miller
2007-11-14  2:05             ` Christoph Lameter
2007-11-14  1:06     ` Andi Kleen
2007-11-14  1:52       ` David Miller
2007-11-14  1:57         ` Christoph Lameter
2007-11-14  2:01           ` David Miller
2007-11-14  2:03             ` Christoph Lameter
2007-11-14  2:28         ` Andi Kleen
2007-11-14  3:48           ` David Miller
2007-11-14  3:49           ` Christoph Lameter
2007-11-16 10:23           ` large lockdep bss (was: Re: [patch 01/28] cpu alloc: The allocator) Peter Zijlstra
2007-11-16 11:44             ` Andi Kleen
2007-11-14  4:15       ` [patch 01/28] cpu alloc: The allocator Christoph Lameter
2007-11-14  4:18         ` David Miller
2007-11-14  4:21           ` David Miller
2007-11-14  4:26           ` Christoph Lameter
2007-11-14  5:53             ` David Miller
2007-11-15 18:49               ` Christoph Lameter
2007-11-15 22:03                 ` David Miller
2007-11-16  2:19                   ` Christoph Lameter
2007-11-16  2:50                     ` David Miller
2007-11-16  2:55                       ` Christoph Lameter
2007-11-16  2:58                         ` David Miller
2007-11-16  3:10                           ` Christoph Lameter
2007-11-16  3:17                             ` David Miller
2007-11-16  3:19                               ` Christoph Lameter
2007-11-06 19:51 ` [patch 02/28] cpu alloc: x86_64 support Christoph Lameter
2007-11-06 19:51 ` [patch 03/28] cpu alloc: IA64 support Christoph Lameter
2007-11-06 19:51 ` [patch 04/28] cpu alloc: i386 support Christoph Lameter
2007-11-06 19:51 ` [patch 05/28] cpu alloc: Use in SLUB Christoph Lameter
2007-11-06 19:51 ` [patch 06/28] cpu alloc: Remove SLUB fields Christoph Lameter
2007-11-06 19:51 ` [patch 07/28] cpu alloc: page allocator conversion Christoph Lameter
2007-11-06 19:51 ` [patch 08/28] cpu alloc: percpu_counter conversion Christoph Lameter
2007-11-06 19:51 ` [patch 09/28] cpu alloc: crash_notes conversion Christoph Lameter
2007-11-06 19:51 ` Christoph Lameter [this message]
2007-11-06 19:51 ` [patch 11/28] cpu alloc: ACPI cstate handling conversion Christoph Lameter
2007-11-06 19:51 ` [patch 12/28] cpu alloc: genhd statistics conversion Christoph Lameter
2007-11-06 19:51 ` [patch 13/28] cpu alloc: blktrace conversion Christoph Lameter
2007-11-06 19:51 ` [patch 14/28] cpu alloc: SRCU Christoph Lameter
2007-11-06 19:51 ` [patch 15/28] cpu alloc: XFS counters Christoph Lameter
2007-11-06 19:52 ` [patch 16/28] cpu alloc: NFS statistics Christoph Lameter
2007-11-06 19:52 ` [patch 17/28] cpu alloc: neigbour statistics Christoph Lameter
2007-11-06 19:52 ` [patch 18/28] cpu alloc: tcp statistics Christoph Lameter
2007-11-06 19:52 ` [patch 19/28] cpu alloc: convert scatches Christoph Lameter
2007-11-06 19:52 ` [patch 20/28] cpu alloc: dmaengine conversion Christoph Lameter
2007-11-06 19:52 ` [patch 21/28] cpu alloc: convert loopback statistics Christoph Lameter
2007-11-06 19:52 ` [patch 22/28] cpu alloc: veth conversion Christoph Lameter
2007-11-06 19:52 ` [patch 23/28] cpu alloc: Chelsio statistics conversion Christoph Lameter
2007-11-06 19:52 ` [patch 24/28] cpu alloc: convert mib handling to cpu alloc Christoph Lameter
2007-11-06 19:52 ` [patch 25/28] cpu alloc: Explicitly code allocpercpu calls in iucv Christoph Lameter
2007-11-06 19:52 ` [patch 26/28] cpu alloc: Use for infiniband Christoph Lameter
2007-11-06 19:52 ` [patch 27/28] cpu alloc: Use in the crypto subsystem Christoph Lameter
2007-11-06 19:52 ` [patch 28/28] cpu alloc: Remove the allocpercpu functionality Christoph Lameter
2007-11-07 13:10 ` [patch 00/28] cpu alloc v1: Optimize by removing arrays of pointers to per cpu objects Martin Schwidefsky
2007-11-07 18:05   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071106195159.940836114@sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox