From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
dhowells@redhat.com, hch@lst.de, apw@shadowen.org
Subject: [PATCH] mm snapshot broken-out-2007-11-06-02-32 - conflict in vxfs_iget ()
Date: Wed, 7 Nov 2007 01:38:07 +0530 [thread overview]
Message-ID: <20071106200807.GC13674@linux.vnet.ibm.com> (raw)
Hi Andrew,
The kernel build fails on S390, with error
CC [M] fs/freevxfs/vxfs_inode.o
fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget'
fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here
fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget'
fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here
make[2]: *** [fs/freevxfs/vxfs_inode.o] Error 1
make[1]: *** [fs/freevxfs] Error 2
make: *** [fs] Error 2
This error is caused by iget-stop-freevxfs-from-using-iget-and-read_inode.patch,
where the function proto type is declared as
vxfs_iget(struct super_block *, unsigned long) and defined as
vxfs_iget(struct super_block *sbp, ino_t ino)
This patch has been tested for the buid failure.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.24-rc1/fs/freevxfs/vxfs_extern.h 2007-11-06 17:04:04.000000000 +0530
+++ linux-2.6.24-rc1/fs/freevxfs/~vxfs_extern.h 2007-11-07 00:45:09.000000000 +0530
@@ -58,7 +58,7 @@ extern struct inode * vxfs_get_fake_ino
extern void vxfs_put_fake_inode(struct inode *);
extern struct vxfs_inode_info * vxfs_blkiget(struct super_block *, u_long, ino_t);
extern struct vxfs_inode_info * vxfs_stiget(struct super_block *, ino_t);
-extern struct inode * vxfs_iget(struct super_block *, unsigned long);
+extern struct inode * vxfs_iget(struct super_block *sbp, ino_t ino);
extern void vxfs_clear_inode(struct inode *);
/* vxfs_lookup.c */
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
next reply other threads:[~2007-11-06 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 20:08 Kamalesh Babulal [this message]
2007-11-06 21:12 ` [PATCH] mm snapshot broken-out-2007-11-06-02-32 - conflict in vxfs_iget () David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106200807.GC13674@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox