Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

Jörn Engel
2007-11-07T18:59:52Z

On Wed, 7 November 2007 10:55:09 -0800, Christoph Lameter wrote:
>
> From: Christoph Lameter <clameter@sgi.com>
> Subject: dcache: use the correct variable.
>
> We need to use "loop" instead of "dentry"
>
> Acked-by: Joern Engel <joern@logfs.org>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
> Index: linux-2.6/fs/dcache.c
> ===================================================================
> --- linux-2.6.orig/fs/dcache.c 2007-11-07 10:26:20.000000000 -0800
> +++ linux-2.6/fs/dcache.c 2007-11-07 10:26:27.000000000 -0800
> @@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub
> spin_lock(&dcache_lock);
> list_for_each_entry(loop, &dentry->d_subdirs,
> d_u.d_child) {
> - dentry_lru_remove(dentry);
> + dentry_lru_remove(loop);
> __d_drop(loop);
> cond_resched_lock(&dcache_lock);
> }

Erm - wouldn't this break git-bisect?

Jörn

--
Joern's library part 5: