Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

Jörn Engel
2007-11-07T09:48:48Z

On Wed, 7 November 2007 09:50:27 +0100, Johannes Weiner wrote:
> On Tue, Nov 06, 2007 at 05:11:34PM -0800, Christoph Lameter wrote:
> > @@ -613,11 +606,7 @@ static void shrink_dcache_for_umount_sub
> > spin_lock(&dcache_lock);
> > list_for_each_entry(loop, &dentry->d_subdirs,
> > d_u.d_child) {
> > - if (!list_empty(&loop->d_lru)) {
> > - dentry_stat.nr_unused--;
> > - list_del_init(&loop->d_lru);
> > - }
> > -
> > + dentry_lru_remove(dentry);
>
> Shouldn't this be dentry_lru_remove(loop)?

Looks like it. Once this is fixed, feel free to add
Acked-by: Joern Engel <joern@logfs.org>

Jörn

--
It does not require a majority to prevail, but rather an irate,
tireless minority keen to set brush fires in people's minds.
-- Samuel Adams