Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

Christoph Lameter
2007-11-07T18:55:24Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1017 bytes --]

On Wed, 7 Nov 2007, Jörn Engel wrote:

> Looks like it. Once this is fixed, feel free to add
> Acked-by: Joern Engel <joern@logfs.org>

Its in the slab defrag git now. I added the spelling fix and this one as a
result of the discussions today.

From: Christoph Lameter <clameter@sgi.com>
Subject: dcache: use the correct variable.

We need to use "loop" instead of "dentry"

Acked-by: Joern Engel <joern@logfs.org>
Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6/fs/dcache.c
===================================================================
--- linux-2.6.orig/fs/dcache.c 2007-11-07 10:26:20.000000000 -0800
+++ linux-2.6/fs/dcache.c 2007-11-07 10:26:27.000000000 -0800
@@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub
spin_lock(&dcache_lock);
list_for_each_entry(loop, &dentry->d_subdirs,
d_u.d_child) {
- dentry_lru_remove(dentry);
+ dentry_lru_remove(loop);
__d_drop(loop);
cond_resched_lock(&dcache_lock);
}