Re: [patch 14/23] inodes: Support generic defragmentation

Jörn Engel
2007-11-07T10:40:53Z

On Wed, 7 November 2007 11:35:13 +0100, Andreas Schwab wrote:
> >
> > The fact that all pointers get changed makes me a bit uneasy:
> > struct foo_inode v[20];
> > ...
> > fs_get_inodes(..., v, ...);
> > ...
> > v[0].foo_field = bar;
> >
> > No warning, but spectacular fireworks.
>
> You'l get a warning that struct foo_inode * is incompatible with void **.
- struct foo_inode v[20];
+ struct foo_inode *v[20];

Looks like my example needs a patch as well. Anyway, the function is
used in a way that makes this a non-issue.

Jörn

--
You cannot suppose that Moliere ever troubled himself to be original in the
matter of ideas. You cannot suppose that the stories he tells in his plays
have never been told before. They were culled, as you very well know.
-- Andre-Louis Moreau in Scarabouche