Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

Johannes Weiner
2007-11-07T08:51:56Z

Hi Christoph,

On Tue, Nov 06, 2007 at 05:11:34PM -0800, Christoph Lameter wrote:
> @@ -613,11 +606,7 @@ static void shrink_dcache_for_umount_sub
> spin_lock(&dcache_lock);
> list_for_each_entry(loop, &dentry->d_subdirs,
> d_u.d_child) {
> - if (!list_empty(&loop->d_lru)) {
> - dentry_stat.nr_unused--;
> - list_del_init(&loop->d_lru);
> - }
> -
> + dentry_lru_remove(dentry);

Shouldn't this be dentry_lru_remove(loop)?

Hannes