From: Andi Kleen <ak@suse.de>
To: "Andreas Herrmann" <andreas.herrmann3@amd.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
"Akinobu Mita" <akinobu.mita@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86: fix cpu-hotplug regression
Date: Wed, 7 Nov 2007 03:35:43 +0100 [thread overview]
Message-ID: <200711070335.44416.ak@suse.de> (raw)
In-Reply-To: <20071107011258.GA31607@alberich.amd.com>
On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote:
> In cases where not all CPUs are brought up during
> boot (e.g. using maxcpus and additional_cpus parameters)
> mce_cpu_callback now returns NOTFIY_BAD because
> for such CPUs cpu_data is not completely filled when
> the notifier is called. Thus mce_create_device fails right
> at its beginning:
>
> if (!mce_available(&cpu_data[cpu]))
> return -EIO;
>
> As a quick fix I suggest to check boot_cpu_data for MCE.
I guess it would be better to just move the device creation
to after the CPU has booted. AKA call mce_create_dev() on CPU_ONLINE
instead.
-Andi
next prev parent reply other threads:[~2007-11-07 2:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 1:12 [PATCH] x86: fix cpu-hotplug regression Andreas Herrmann
2007-11-07 2:35 ` Andi Kleen [this message]
2007-11-07 13:18 ` Andreas Herrmann
2007-11-07 14:15 ` Akinobu Mita
2007-11-09 20:16 ` Andrew Morton
2007-11-12 10:07 ` Andreas Herrmann
2007-11-12 17:38 ` [PATCH] x86: don't call mce_create_device on CPU_UP_PREPARE Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711070335.44416.ak@suse.de \
--to=ak@suse.de \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox