From: Jens Axboe <jens.axboe@oracle.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick <gentuu@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfq: fix IOPRIO_CLASS_IDLE delays
Date: Wed, 7 Nov 2007 13:50:57 +0100 [thread overview]
Message-ID: <20071107125057.GF5525@kernel.dk> (raw)
In-Reply-To: <20071107134855.GA5947@tv-sign.ru>
On Wed, Nov 07 2007, Oleg Nesterov wrote:
> On 11/06, Jens Axboe wrote:
> >
> > On Tue, Nov 06 2007, Oleg Nesterov wrote:
> > >
> > > (I guess this patch is not complete, overflow is still possible)
> >
> > Hmm, where would it overflow?
>
> What if the queue was idle long enough (no !CLASS_IDLE requests) so that
> jiffies wraps into the past wrt ->last_end_request?
>
> IOW, perhaps something like the patch below makes some sense. Of course,
> this is only a theoretical problem, I'm not sure we really need a fix.
OK I see what you mean, probably pretty much a theoretical problem only.
But that doesn't mean it should be fixed, I've applied your patch. It
also collects the two paths enabling the idle class timer, so I consider
it a cleanup as well as it improves readability.
--
Jens Axboe
prev parent reply other threads:[~2007-11-07 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 20:05 [PATCH] cfq: fix IOPRIO_CLASS_IDLE delays Oleg Nesterov
2007-11-06 19:26 ` Jens Axboe
2007-11-07 13:48 ` Oleg Nesterov
2007-11-07 12:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107125057.GF5525@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=gentuu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox