From: Paul Mundt <lethal@linux-sh.org>
To: Steve Grubb <sgrubb@redhat.com>
Cc: Yuichi Nakamura <ynakam@hitachisoft.jp>,
linux-kernel@vger.kernel.org, linuxsh-dev@lists.sourceforge.net,
Al Viro <aviro@redhat.com>
Subject: Re: [patch] audit support for SH
Date: Thu, 8 Nov 2007 00:24:39 +0900 [thread overview]
Message-ID: <20071107152439.GA28272@linux-sh.org> (raw)
In-Reply-To: <200711071015.33765.sgrubb@redhat.com>
On Wed, Nov 07, 2007 at 10:15:33AM -0500, Steve Grubb wrote:
> On Wednesday 07 November 2007 12:04:46 am Yuichi Nakamura wrote:
> > I found syscall audit does not work on SH(SuperH).
> > I made patch to support syscall audit for SH.
>
> I think this is close, but it looks like you missed the syscall classification
> piece. You can find an example here:
>
> arch/x86_64/kernel/audit.c
>
> Its used for determining which syscalls we are interested in for watches.
>
Looking at this, it seems like the classification stuff for 32-bit is
generic, it's just the compat bits that are special cased and wrap back
in through the 32-bit classifier.
Is there any point in keeping the 32-bit audit.c rather than simply
moving it to kernel/ or lib/ and leaving the arch/ bits as compat
wrappers only?
At least powerpc, x86, and ia64 look like they could go that way.
next prev parent reply other threads:[~2007-11-07 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 5:04 [patch] audit support for SH Yuichi Nakamura
2007-11-07 5:30 ` Paul Mundt
2007-11-07 15:15 ` Steve Grubb
2007-11-07 15:24 ` Paul Mundt [this message]
2007-11-08 8:16 ` Yuichi Nakamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107152439.GA28272@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=aviro@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxsh-dev@lists.sourceforge.net \
--cc=sgrubb@redhat.com \
--cc=ynakam@hitachisoft.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox