From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: paulus@samba.org, lkml@davidb.org, linux-kernel@vger.kernel.org,
drepper@redhat.com, mtk-manpages@gmx.net
Subject: Re: compat_sys_times() bogus until jiffies >= 0.
Date: Wed, 7 Nov 2007 23:09:16 -0800 [thread overview]
Message-ID: <20071107230916.fa301e5a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071107.222530.156152513.davem@davemloft.net>
> On Wed, 07 Nov 2007 22:25:30 -0800 (PST) David Miller <davem@davemloft.net> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 7 Nov 2007 21:20:05 -0800
>
> > Yup. But userspace will already have a fit if either the start or end time
> > advanced into the glibc-thought-that-was-an-error range.
>
> On x86 only. We could use force_successful_syscall_return()
> to make sure the condition codes get set correctly on
> other platforms.
>
> But even in that case we'd still be broken when the return
> value is exactly -1 and that's what the application is going
> to compare against to test for errors.
I don't think that's a big problem? This syscall can (oddly) return any
32-bit (64-bit) number and a smart application developer (after saying wtf)
would realise that he just can't check for errors and have correctly
working code.
Then again, if he was smart he just wouldn't use times(2)'s return value
for anything. But what is the alternative? I don't think there is one,
apart from much saner things like gettimeofday().
next prev parent reply other threads:[~2007-11-08 7:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 22:47 compat_sys_times() bogus until jiffies >= 0 David Brown
2007-11-07 23:28 ` Andrew Morton
2007-11-08 0:18 ` Andrew Morton
2007-11-08 0:54 ` Andreas Schwab
2007-11-08 1:17 ` Andrew Morton
2007-11-08 1:53 ` Paul Mackerras
2007-11-08 2:09 ` David Miller
2007-11-08 10:20 ` Andreas Schwab
2007-11-08 14:42 ` Chris Friesen
2007-11-09 18:20 ` Ulrich Drepper
2007-12-20 11:36 ` Michael Kerrisk
2007-12-20 11:51 ` David Miller
2007-12-22 0:42 ` Andi Kleen
2007-12-22 1:41 ` David Miller
2007-12-22 1:45 ` David Miller
2007-12-22 1:53 ` Andi Kleen
2007-12-22 4:36 ` David Miller
2007-12-22 12:47 ` Andi Kleen
2007-12-22 1:49 ` Andi Kleen
2007-11-08 19:25 ` Denys Vlasenko
2007-11-08 3:07 ` Andrew Morton
2007-11-08 3:13 ` David Miller
2007-11-08 5:15 ` Paul Mackerras
2007-11-08 6:24 ` David Miller
2007-11-08 4:59 ` Paul Mackerras
2007-11-08 5:20 ` Andrew Morton
2007-11-08 5:36 ` Paul Mackerras
2007-11-08 6:12 ` Andrew Morton
2007-11-08 6:25 ` David Miller
2007-11-08 7:09 ` Andrew Morton [this message]
2007-11-08 7:14 ` David Miller
2007-11-08 8:53 ` Paul Mackerras
2007-11-08 6:22 ` David Miller
2007-11-08 19:27 ` Denys Vlasenko
2007-11-08 0:50 ` David Miller
2007-11-08 1:13 ` Andrew Morton
2007-11-08 6:00 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107230916.fa301e5a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@davidb.org \
--cc=mtk-manpages@gmx.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox