From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: rjw@sisk.pl, hannes-kernel@saeurebad.de, listen@selfservix.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>
Subject: Re: 2.6.24-rc1: OOPS at acpi_battery_update
Date: Fri, 9 Nov 2007 01:49:44 -0800 [thread overview]
Message-ID: <20071109014944.26adf4e0.akpm@linux-foundation.org> (raw)
In-Reply-To: <47342A2B.5020006@suse.de>
On Fri, 09 Nov 2007 12:36:43 +0300 Alexey Starikovskiy <astarikovskiy@suse.de> wrote:
> Andrew Morton wrote:
> > A> On Thu, 08 Nov 2007 19:35:23 +0300 Alexey Starikovskiy <astarikovskiy@suse.de> wrote:
> >> [remove_cycle_at_battery_removal.patch text/x-patch (1.7KB)]
> >> ACPI: Battery: remove cycle from battery removal.
> >>
> >> From: Alexey Starikovskiy <astarikovskiy@suse.de>
> >>
> >> get_property() should not call battery_update() on absent battery to
> >> avoid cycle and oops.
> >>
> >> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> >> Tested-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> >
> > A patch similar to this one but with an identical changelog was merged into
> > Len's tree on November 2.
> >
> > If it had been promptly merged into mainline then quite a lot of people's
> > time would not have been wasted.
> >
> Andrew,
> should I send such patches directly to you/Linus?
>
Well if Len doesn't object and you're confident in the changes, why not?
Any time we leave bugs unfixed we drive away testers and that impacts all
parts of the kernel.
next prev parent reply other threads:[~2007-11-09 9:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 10:11 2.6.24-rc1: OOPS at acpi_battery_update Romano Giannetti
2007-11-01 23:14 ` Andrew Morton
2007-11-02 16:08 ` Rafael J. Wysocki
2007-11-04 9:34 ` *SPAM* " Romano Giannetti
2007-11-04 13:17 ` Rafael J. Wysocki
2007-11-04 23:29 ` Michael (rabenkind) Brandstetter
2007-11-05 0:18 ` Rafael J. Wysocki
2007-11-08 15:53 ` Johannes Weiner
2007-11-08 16:16 ` Rafael J. Wysocki
2007-11-08 16:11 ` Alexey Starikovskiy
2007-11-08 16:46 ` Johannes Weiner
2007-11-08 16:35 ` Alexey Starikovskiy
2007-11-08 16:58 ` Johannes Weiner
2007-11-09 4:34 ` Andrew Morton
2007-11-09 9:36 ` Alexey Starikovskiy
2007-11-09 9:49 ` Andrew Morton [this message]
2007-11-13 8:35 ` Alexey Starikovskiy
2007-11-13 8:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109014944.26adf4e0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=astarikovskiy@suse.de \
--cc=hannes-kernel@saeurebad.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=listen@selfservix.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox