* [2.6 patch] x86 pci-calgary_64.c: make a variable static
@ 2007-11-09 6:03 Adrian Bunk
2007-11-11 8:35 ` Muli Ben-Yehuda
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-11-09 6:03 UTC (permalink / raw)
To: muli, jdmason, tglx, mingo, hpa; +Cc: linux-kernel
"debugging" is a horrible name for a global variable - thankfully it can
become static.
Also put it out of __read_mostly so that gcc no longer has to emit it
at all.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/x86/kernel/pci-calgary_64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
22f49393bbb5d8e73f94338be5d1ad52f459779c
diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
index 6bf1f71..a262f94 100644
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -183,7 +183,7 @@ static struct calgary_bus_info bus_info[MAX_PHB_BUS_NUM] = { { NULL, 0, 0 }, };
/* enable this to stress test the chip's TCE cache */
#ifdef CONFIG_IOMMU_DEBUG
-int debugging __read_mostly = 1;
+static int debugging = 1;
static inline unsigned long verify_bit_range(unsigned long* bitmap,
int expected, unsigned long start, unsigned long end)
@@ -202,7 +202,7 @@ static inline unsigned long verify_bit_range(unsigned long* bitmap,
return ~0UL;
}
#else /* debugging is disabled */
-int debugging __read_mostly = 0;
+static int debugging = 0;
static inline unsigned long verify_bit_range(unsigned long* bitmap,
int expected, unsigned long start, unsigned long end)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [2.6 patch] x86 pci-calgary_64.c: make a variable static
2007-11-09 6:03 [2.6 patch] x86 pci-calgary_64.c: make a variable static Adrian Bunk
@ 2007-11-11 8:35 ` Muli Ben-Yehuda
0 siblings, 0 replies; 2+ messages in thread
From: Muli Ben-Yehuda @ 2007-11-11 8:35 UTC (permalink / raw)
To: Adrian Bunk; +Cc: jdmason, tglx, mingo, hpa, linux-kernel
On Fri, Nov 09, 2007 at 07:03:30AM +0100, Adrian Bunk wrote:
> "debugging" is a horrible name for a global variable - thankfully it can
> become static.
>
> Also put it out of __read_mostly so that gcc no longer has to emit it
> at all.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Thanks, applied. Will push with my next batch of Calgary updates.
Cheers,
Muli
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-11 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-09 6:03 [2.6 patch] x86 pci-calgary_64.c: make a variable static Adrian Bunk
2007-11-11 8:35 ` Muli Ben-Yehuda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox