* [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.
@ 2007-11-10 9:41 Kamalesh Babulal
2007-11-10 10:24 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Kamalesh Babulal @ 2007-11-10 9:41 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds, akpm, dada1, davem, apw
Hi,
The 2.6.24-rc2-git1 kernel build fails, with following error
CC security/selinux/hooks.o
In file included from include/net/tcp.h:35,
from security/selinux/hooks.c:52:
include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc'
include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast
include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree'
make[2]: *** [security/selinux/hooks.o] Error 1
make[1]: *** [security/selinux] Error 2
make: *** [security] Error 2
The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per
bucket rwlock in tcp/dccp ehash table.) caused this build
failure.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
index 8461cda..469216d 100644
--- a/include/net/inet_hashtables.h
+++ b/include/net/inet_hashtables.h
@@ -23,6 +23,7 @@
#include <linux/spinlock.h>
#include <linux/types.h>
#include <linux/wait.h>
+#include <linux/vmalloc.h>
#include <net/inet_connection_sock.h>
#include <net/inet_sock.h>
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.
2007-11-10 9:41 [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks Kamalesh Babulal
@ 2007-11-10 10:24 ` Eric Dumazet
2007-11-10 10:48 ` Kamalesh Babulal
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2007-11-10 10:24 UTC (permalink / raw)
To: Kamalesh Babulal; +Cc: linux-kernel, torvalds, akpm, davem, apw
Kamalesh Babulal a écrit :
> Hi,
>
> The 2.6.24-rc2-git1 kernel build fails, with following error
>
> CC security/selinux/hooks.o
> In file included from include/net/tcp.h:35,
> from security/selinux/hooks.c:52:
> include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
> include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc'
> include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast
> include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
> include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree'
> make[2]: *** [security/selinux/hooks.o] Error 1
> make[1]: *** [security/selinux] Error 2
> make: *** [security] Error 2
>
> The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per
> bucket rwlock in tcp/dccp ehash table.) caused this build
> failure.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> --
> diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
> index 8461cda..469216d 100644
> --- a/include/net/inet_hashtables.h
> +++ b/include/net/inet_hashtables.h
> @@ -23,6 +23,7 @@
> #include <linux/spinlock.h>
> #include <linux/types.h>
> #include <linux/wait.h>
> +#include <linux/vmalloc.h>
>
> #include <net/inet_connection_sock.h>
> #include <net/inet_sock.h>
>
Yes, same patch was posted some hours ago, but Tony didnt acknowledged it.
http://marc.info/?l=linux-kernel&m=119465902731847&w=2
Thank you
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.
2007-11-10 10:24 ` Eric Dumazet
@ 2007-11-10 10:48 ` Kamalesh Babulal
0 siblings, 0 replies; 3+ messages in thread
From: Kamalesh Babulal @ 2007-11-10 10:48 UTC (permalink / raw)
To: Eric Dumazet; +Cc: linux-kernel, torvalds, akpm, davem, apw
Eric Dumazet wrote:
> Kamalesh Babulal a écrit :
>> Hi,
>>
>> The 2.6.24-rc2-git1 kernel build fails, with following error
>>
>> CC security/selinux/hooks.o
>> In file included from include/net/tcp.h:35,
>> from security/selinux/hooks.c:52:
>> include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
>> include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc'
>> include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast
>> include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
>> include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree'
>> make[2]: *** [security/selinux/hooks.o] Error 1
>> make[1]: *** [security/selinux] Error 2
>> make: *** [security] Error 2
>>
>> The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per
>> bucket rwlock in tcp/dccp ehash table.) caused this build
>> failure.
>>
>> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>> --
>> diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
>> index 8461cda..469216d 100644
>> --- a/include/net/inet_hashtables.h
>> +++ b/include/net/inet_hashtables.h
>> @@ -23,6 +23,7 @@
>> #include <linux/spinlock.h>
>> #include <linux/types.h>
>> #include <linux/wait.h>
>> +#include <linux/vmalloc.h>
>>
>> #include <net/inet_connection_sock.h>
>> #include <net/inet_sock.h>
>>
>
> Yes, same patch was posted some hours ago, but Tony didnt acknowledged it.
>
> http://marc.info/?l=linux-kernel&m=119465902731847&w=2
>
> Thank you
> -
Hi Eric,
Thank you and sorry for the noise.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-10 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-10 9:41 [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks Kamalesh Babulal
2007-11-10 10:24 ` Eric Dumazet
2007-11-10 10:48 ` Kamalesh Babulal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox