Re: [RFC 4/13] Char: nozomi, tty index cleanup

Jiri Slaby
2007-11-10T15:50:39Z

On 11/10/2007 04:41 PM, Frank Seidel wrote:
> On Samstag 10 November 2007 00:45:30, you (Jiri Slaby) wrote:
>> nozomi, tty index cleanup
>>
>> - don't store unneeded copy of tty->index into port structure, tty->index
>> is available everywhere
>> - mod tty->index by MAX_PORT where expected (otherwise array index out of
>> bounds)
> The last point i can't retrace, as all those parts were already IMHO.
> NTTY_TTY_MINORS is just an alias for MAX_PORT, but of course its much
> better readable and also shorter. But i doubt this prevents to an array
> index to get out of bounds ;-)

Aha, this is comment from old patch (before you made the same fixes in c version
of the driver), where I added % in some places, e.g. index of port in dc
structure...

regards,
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University