Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

Roman Zippel
2007-11-15T19:43:39Z

Hi,

On Thu, 15 Nov 2007, Sam Ravnborg wrote:

> > > The value can be supplied on the command-line so we need to validate input.
> >
> > Is there a need for this?
> Yes. We would like to set 64BIT or not in other than x86 cases.
> And way forward was not to override ARCH as in the x86 case.

Can we please can get some consistency in this?
We have a .config file for a reason, what's wrong with using it?

> > Please revert the K64BIT changes and use this instead.
>
> I will finish up your patch and target it for next merge window.

Why can't this be fixed properly now? You don't even need this patch, just
use ARCH to set 64BIT in the Kconfig as I've shown.

> > These are two different uses, when reading a .config only the basic syntax
> > is checked, but not the value itself.
> This is wrong considering the amount of people that hand edit the .config file.

It's not, the actual symbol value is set later depending on the dependency
constraints.

bye, Roman