Re: kconfig: support option env="" [Was: kconfig: use $K64BIT to set 64BIT with all*config targets]

Roman Zippel
2008-01-14T03:50:07Z

Hi,

On Sun, 6 Jan 2008, Sam Ravnborg wrote:

> Please get back to me so we can finsih this patch and have it applied.
> I will split the patch in two btw.

I reworked the patch a little and split it into three.

> > + if (sym->flags & SYMBOL_AUTO)
> > + sym->flags &= ~SYMBOL_WRITE;
> > +
>
> Why is this change needed?
> It is non-obvious to me so please explain and I will add a comment.

Automatically generated symbols are not saved, this was previously not
needed as they weren't in the menu structure.

> I did it like this:
> menu_warn(current_entry,
> "config %s: redefining environment symbol from '%s' to '%s'",
> sym->name, env, sym2->name);

I omitted the prefix, it's inconsistent with other warnings.

bye, Roman