Re: [PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

Randy Dunlap
2007-11-10T22:35:00Z

On Sat, 10 Nov 2007 21:40:38 +0100 Sam Ravnborg wrote:

> As discussed in another thread the right thing is to add a generic solution
> to select between 32 and 64 bit - useable for powerpc, s390, ppc et al.
>
> First step was to teach kconfig how to force 64BIT to a specific value.
> The x86 Kconfig file needed a small twist to use 64BIT as the symbol
> to seelct 32 or 64 bit.
> Then it was simple to add backward compatibility ARCH= settings.
>
> The patchset is not yet pushed out - I will await a bit feedback first.
>
> Shortlog and diffstat.
> kconfig: factor out code in confdata.c
> kconfig: use $K64BIT to set 64BIT with all*config targets
> x86: Use CONFIG_64BIT to select between 32 and 64 bit in Kconfig
> kconfig: document make K64BIT=y in README
> x86: introduce ARCH=i386,ARCH=x86_64 to select 32/64 bit

Hi Sam,
Looks good to me and should satisfy our habits^w usages models.

The one minor question is the environment variable name (K64BIT or
something else, like Guillaume brought up). Personally I don't
care how it's spelled. IOW, K64BIT is sufficient, but if there is a
goal to be able to place any CONFIG_symbol on the command line or
as an env. variable, they might as well all be named with CONFIG_*.

Thanks,
---
~Randy