Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

Ingo Molnar
2007-11-11T20:45:26Z

* Erez Zadok <ezk@cs.sunysb.edu> wrote:

> Ingo, I don't see how it can return NULL. This is what get_task_comm
> looks like in MMOTM-2007-11-10-19-05:
>
> char *get_task_comm(char *buf, struct task_struct *tsk)
> {
> /* buf must be at least sizeof(tsk->comm) in size */
> task_lock(tsk);
> strncpy(buf, tsk->comm, sizeof(tsk->comm));
> task_unlock(tsk);
> return buf;
> }
>
> The only way it'd return NULL is if a null buf was passed, in which
> case the strncpy will oops first.

hm, here it says in include/linux/sched.h:

extern void get_task_comm(char *to, struct task_struct *tsk);

HEAD ecd744eec3a.

Ingo