Re: [patch 1/6] x86: apicdef unification: some constants made unsigned

Robert Richter
2007-11-08T10:15:41Z

On 07.11.07 12:41:09, Jeremy Fitzhardinge wrote:
> > -#define GET_APIC_VERSION(x) ((x)&0xFF)
> > -#define GET_APIC_MAXLVT(x) (((x)>>16)&0xFF)
> > -#define APIC_INTEGRATED(x) ((x)&0xF0)
> > +#define GET_APIC_VERSION(x) ((x)&0xFFu)
> > +#define GET_APIC_MAXLVT(x) (((x)>>16)&0xFFu)
> > +#define APIC_INTEGRATED(x) ((x)&0xF0u)
>
> Can these ever be used in .S files? Might be better to use the _AC stuff.

I did not want to make functional changes, just do a simple
merge. However there are already updated files in the x86/cleanup
tree, so these patches are obsolete.

-Robert