Re: [patch 1/6] x86: apicdef unification: some constants made unsigned

Jeremy Fitzhardinge
2007-11-07T20:41:32Z

Robert Richter wrote:
> -#define GET_APIC_VERSION(x) ((x)&0xFF)
> -#define GET_APIC_MAXLVT(x) (((x)>>16)&0xFF)
> -#define APIC_INTEGRATED(x) ((x)&0xF0)
> +#define GET_APIC_VERSION(x) ((x)&0xFFu)
> +#define GET_APIC_MAXLVT(x) (((x)>>16)&0xFFu)
> +#define APIC_INTEGRATED(x) ((x)&0xF0u)

Can these ever be used in .S files? Might be better to use the _AC stuff.

J