From: Andi Kleen <andi@firstfloor.org>
To: Jan Glauber <jang@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Pavel Emelyanov <xemul@openvz.org>,
Andi Kleen <andi@firstfloor.org>,
Jon Masters <jonathan@jonmasters.org>
Subject: Re: [PATCH] module loader should not complain about unknown symbol
Date: Mon, 12 Nov 2007 17:59:53 +0100 [thread overview]
Message-ID: <20071112165952.GA26064@one.firstfloor.org> (raw)
In-Reply-To: <1194877107.5656.31.camel@localhost.localdomain>
On Mon, Nov 12, 2007 at 02:18:27PM +0000, Jan Glauber wrote:
> If module A depends on module B and module B has not yet finished its
> init() the module loader may print a warning about an unknown symbol.
>
> This happens if module B is still in state MODULE_STATE_COMING,
> as module A runs into resolve_symbol() for a symbol from module B.
> resolve_symbol() return 0 in that case and causes the warning.
I don't think that patch is a good idea. It points to a kernel problem of
some sort that needs to be resolved. Making it fail silently is not
an improvement.
Also how else should the user know about "legitimate" (not caused by races)
unresolved symbols?
-Andi
next prev parent reply other threads:[~2007-11-12 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 14:18 [PATCH] module loader should not complain about unknown symbol Jan Glauber
2007-11-12 16:59 ` Andi Kleen [this message]
2007-11-12 22:23 ` Rusty Russell
2007-11-13 2:52 ` Rusty Russell
2007-11-13 4:08 ` Peter Teoh
2007-11-13 4:40 ` Rusty Russell
2007-11-13 4:55 ` Jon Masters
2007-11-14 12:12 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112165952.GA26064@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jang@linux.vnet.ibm.com \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox