From: Amit Shah <amit.shah@qumranet.com>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH 5/8] KVM: PVDMA: Update dma_alloc_coherent to make it paravirt-aware
Date: Mon, 12 Nov 2007 17:29:33 +0530 [thread overview]
Message-ID: <200711121729.33458.amit.shah@qumranet.com> (raw)
In-Reply-To: <20071112105637.GH3299@rhun.haifa.ibm.com>
On Monday 12 November 2007 16:26:37 Muli Ben-Yehuda wrote:
> On Wed, Nov 07, 2007 at 04:21:06PM +0200, Amit Shah wrote:
> > Of all the DMA calls, only dma_alloc_coherent might not actually
> > call dma_ops->alloc_coherent. We make sure that gets called if the
> > device that's being worked on is a PV device
>
> I always thougt that's a mess... the reason it's done this way is that
> Andi Kleen preferred it for some reason at the time. How about trying
> to fix it cleanly so that dma_alloc_coherent always gets called rather
> than adding a hack to work around a hack? It will require auditing all
> of the different x86 dma-ops but I can help with that.
Hmm, nice to know it's like that just because of "not necessary now".
Fixing this along with stacking dma_ops and making 32-bit also dma_ops-ready
will greatly simplify things.
>
> Cheers,
> Muli
next prev parent reply other threads:[~2007-11-12 12:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 14:21 RFC: Paravirtualized DMA accesses for KVM Amit Shah
[not found] ` <d1c72ce6e3a0e73c18993c3f066d1350b147f726.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 1/8] KVM: PVDMA Host: Handle reqeusts for guest DMA mappings Amit Shah
[not found] ` <6d486436cf50e269d8914229d10ff60f3d646795.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 2/8] KVM: Move #include asm/kvm_para.h outside of __KERNEL__ Amit Shah
[not found] ` <218cf425feff1d4daf23d3f25df1eb224108a1a3.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 4/8] KVM: PVDMA: Introduce is_pv_device() dma operation Amit Shah
2007-11-12 10:52 ` [kvm-devel] " Muli Ben-Yehuda
[not found] ` <6bbd61409e4779febab1eaf03796455b22e8ea70.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 6/8] KVM: PVDMA Guest: Add Makefile rule Amit Shah
[not found] ` <01dd7657bda537d738ea92330606592fa8aaf3c5.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 7/8] PVDMA: Guest: Add Kconfig options to select PVDMA Amit Shah
[not found] ` <fbc5dea9bfdb021ab2d3808583314901799405a0.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 8/8] KVM: Update drivers/Makefile to check for CONFIG_VIRTUALIZATION Amit Shah
[not found] ` <609d5d611a5fb58ab5a7184be7b6d29494023ba0.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA Amit Shah
2007-11-12 10:50 ` [kvm-devel] " Muli Ben-Yehuda
2007-11-12 11:56 ` Amit Shah
2007-11-12 13:32 ` Muli Ben-Yehuda
2007-11-12 13:55 ` Amit Shah
2007-11-12 14:01 ` Muli Ben-Yehuda
2007-11-12 14:53 ` Gerd Hoffmann
2007-11-12 16:00 ` Joerg Roedel
[not found] ` <e2f5f0c08d08cf66a39c8b452410078617e611f7.1194445109.git.amit.shah@qumranet.com>
2007-11-07 14:21 ` [PATCH 5/8] KVM: PVDMA: Update dma_alloc_coherent to make it paravirt-aware Amit Shah
2007-11-12 10:56 ` [kvm-devel] " Muli Ben-Yehuda
2007-11-12 11:59 ` Amit Shah [this message]
2007-11-12 15:55 ` [kvm-devel] [PATCH 1/8] KVM: PVDMA Host: Handle reqeusts for guest DMA mappings Joerg Roedel
2007-11-12 17:07 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711121729.33458.amit.shah@qumranet.com \
--to=amit.shah@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox