From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <ak@suse.de>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] arch/x86/kernel/setup_64.c compile error (MMOTM-2007-11-10-19-05)
Date: Mon, 12 Nov 2007 17:47:21 -0800 [thread overview]
Message-ID: <20071112174721.c304264d.akpm@linux-foundation.org> (raw)
In-Reply-To: <200711130232.29900.ak@suse.de>
On Tue, 13 Nov 2007 02:32:29 +0100 Andi Kleen <ak@suse.de> wrote:
>
> > hm, that doesn't seem right. We want to run the early quirks on non-ACPI
> > kernel too, surely?
>
> Most of early-quirks.c makes only sense with ACPI. The only exception would
> be the ATI timer override check, but frankly it's fairly unlikely that there
> are any ATI based boards around who still have mptables. Non ACPI
> tables would very likely just run in PIC mode and then need no timer overrides
> anyways.
>
> Originally on i386 the early quirks equivalent was 100% ACPI specific.
>
OK.... But what's The Right Thing To Do here? Would one be reasonable in
expecting that one can add a new early quirk which is independent from acpi
and have it still work on non-acpi builds?
Seems better to decouple the two things if poss?
next prev parent reply other threads:[~2007-11-13 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 22:34 [PATCH] arch/x86/kernel/setup_64.c compile error (MMOTM-2007-11-10-19-05) Erez Zadok
2007-11-13 1:28 ` Andrew Morton
2007-11-13 1:32 ` Andi Kleen
2007-11-13 1:47 ` Andrew Morton [this message]
2007-11-13 8:26 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112174721.c304264d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox