Re: [PATCH 1/3]: tty - fix network driver interactions with TCGET/SET calls

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 2 Nov 2007 15:33:29 +0000 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> Dave Miller noted various cases where line disciplines for things like
> ppp go poking around in termios themselves in ways that broke with the
> new termios code. Rather than have them all learning about termios
> internals provide proper methods for this
> 
> - tty_mode_ioctl()
> 
> 	This handles all the terminal mode handling for speed/carrier etc
> and none of the methods are ldisc dependant so they can be called by any
> user
> 
> - tty_perform_flush()
> 
> 	This extracts the flush functionality and enables pppd the ppp
> layer to share it cleanly.
> 
> 
> The existing n_tty_ioctl code is refactored in this patch to provide the
> new functions and to call them itself appropriately. This patch has no
> (intended) behaviour changes and simply prepares for the other fixes.

net/irda/irnet/irnet_ppp.c: In function 'dev_irnet_ioctl':
net/irda/irnet/irnet_ppp.c:738: warning: passing argument 2 of 'kernel_termios_to_user_termios_1' from incompatible pointer type
net/irda/irnet/irnet_ppp.c:750: warning: passing argument 1 of 'user_termios_to_kernel_termios_1' from incompatible pointer type