Re: checkpatch.pl and no newline handling

Andy Whitcroft
2007-11-13T10:55:26Z

On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote:
> the current checkpatch.pl does not reject new files that lack a
> newline, yet rejects patches that fix newlines in files ... quite the
> opposite of what we actually want

apw@pinky$ echo -n "moo" >no-newline.c
apw@pinky$ diff -Nu /dev/null no-newline.c | ./checkpatch.pl -q -no-tree
--no-signoff -
WARNING: adding a line without newline at end of file
#4: FILE: no-newline.c:1:
+moo

total: 0 errors, 1 warnings, 1 lines checked
apw@pinky$ echo "moo" >newline.c
apw@pinky$ diff -Nu no-newline.c newline.c | ./checkpatch.pl -q -no-tree
--no-signoff -
total: 0 errors, 0 warnings, 3 lines checked
apw@pinky$

This should be fixed in the 0.12 release and is fixed in -next.

-apw