Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated)

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 13 Nov 2007 14:34:19 +0100 "Thomas Lindroth" <thomas.lindroth@gmail.com> wrote:

> >
> > On Sun, 11 Nov 2007 22:46:43 +0000 Alan Cox <alan@lxorguk.ukuu.org.uk>
> > wrote:
> >
> > > > [PATCH] pata_amd/pata_via: de-couple programming of PIO/MWDMA and UDMA
> > timings
> > > >
> > > > * Don't program UDMA timings when programming PIO or MWDMA modes.
> > > >
> > > >   This has also a nice side-effect of fixing regression added by
> > commit
> > > >   681c80b5d96076f447e8101ac4325c82d8dce508 ("libata: correct handling
> > of
> > > >   SRST reset sequences") (->set_piomode method for PIO0 is called
> > before
> > > >   ->cable_detect method which checks UDMA timings to get the cable
> > type).
> > >
> > > I'm not sure this helps as if the ACPI _GTF method is looking at the
> > > flags and stuff but it has to be worth a try.
> > >
> > >
> > > Works for me as a 2.6.24 band aid
> >
> > I'm looking at that "Untested, please don't merge until it is confirmed to
> > fix the problem." comment..
> >
> > Thomas, can you please give it a try, let us know?
> >
> > Thanks
> >
> 
> I can confirm that the patch "pata_amd/pata_via: de-couple programming of
> PIO/MWDMA and UDMA timings" does fix my issue "pata_amd fails to detect
> 80-pin wire".
> 

Great, thanks for testing it.

I moved that patch to the "to send to maintainers as a 2.6.24 fix" queue. 
I should get all that material sent out hopefully tomorrow, if I can manage
to get 2.6.24-rc2-mm1 to limp out the door.