From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@suse.de, apw@shadowen.org
Subject: Re: mm snapshot broken-out-2007-11-13-04-14 Build Fails due kobject cleanup (Resend)
Date: Tue, 13 Nov 2007 20:52:29 +0530 [thread overview]
Message-ID: <20071113152229.GB32528@linux.vnet.ibm.com> (raw)
In-Reply-To: <200711131215.lADCFfht009739@imap1.linux-foundation.org>
Hi Andrew,
The build fails, with the build error
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/pci/hotplug/rpadlpar_sysfs.c:59: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:79: error: expected ˜; before ˜return
drivers/pci/hotplug/rpadlpar_sysfs.c: At top level:
drivers/pci/hotplug/rpadlpar_sysfs.c:89: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c:92: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:80: warning: control reaches end of non-void function
make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2
This is caused by the patch
gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.24-rc2/drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-13 19:42:26.000000000 +0530
+++ linux-2.6.24-rc2/drivers/pci/hotplug/~rpadlpar_sysfs.c 2007-11-13 20:29:09.000000000 +0530
@@ -54,7 +54,7 @@ static ssize_t add_slot_show(struct kobj
return sprintf(buf, "0\n");
}
-static ssize_t remove_slot_store(struct kobjet *kobj,
+static ssize_t remove_slot_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t nbytes)
{
@@ -74,7 +74,7 @@ static ssize_t remove_slot_store(struct
rc = dlpar_remove_slot(drc_name);
if (rc)
- return rc
+ return rc;
return nbytes;
}
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
next prev parent reply other threads:[~2007-11-13 15:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 12:15 mm snapshot broken-out-2007-11-13-04-14.tar.gz uploaded akpm
2007-11-13 12:40 ` cscope build warning [Was: mm snapshot broken-out-2007-11-13-04-14.tar.gz uploaded] Jiri Slaby
2007-11-13 13:27 ` Sam Ravnborg
2007-11-13 13:36 ` Jiri Slaby
2007-11-13 12:50 ` nfs functions undefined " Jiri Slaby
2007-11-13 17:34 ` [PATCH] " Randy Dunlap
2007-11-13 19:43 ` Andrew Morton
2007-11-13 14:43 ` mm snapshot broken-out-2007-11-13-04-14 Build Fails at memory.c Kamalesh Babulal
2007-11-13 15:17 ` Martin Schwidefsky
2007-11-13 15:30 ` Kamalesh Babulal
2007-11-13 15:29 ` Martin Schwidefsky
2007-11-13 15:11 ` mm snapshot broken-out-2007-11-13-04-14 Build Fails due kobject cleanup Kamalesh Babulal
2007-11-13 15:22 ` Kamalesh Babulal [this message]
2007-11-13 19:51 ` mm snapshot broken-out-2007-11-13-04-14 Build Fails - linking when !CONFIG_NFS_V4 Kamalesh Babulal
2007-11-14 5:23 ` Randy Dunlap
2007-11-14 0:20 ` mm snapshot broken-out-2007-11-13-04-14.tar.gz uploaded Kevin Winchester
2007-11-14 1:11 ` Andrew Morton
2007-11-14 1:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113152229.GB32528@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox