public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	prasanna@in.ibm.com, anil.s.keshavamurthy@intel.com,
	davem@davemloft.net
Subject: [patch 3/8] Immediate Values - Move Kprobes x86 restore_interrupt to kdebug.h
Date: Tue, 13 Nov 2007 13:58:03 -0500	[thread overview]
Message-ID: <20071113190040.090133515@polymtl.ca> (raw)
In-Reply-To: 20071113185800.436425570@polymtl.ca

[-- Attachment #1: immediate-values-move-kprobes-x86-restore-interrupt-to-kdebug-h.patch --]
[-- Type: text/plain, Size: 3272 bytes --]

Since the breakpoint handler is useful both to kprobes and immediate values, it
makes sense to make the required restore_interrupt() available through
asm-i386/kdebug.h.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
CC: Christoph Hellwig <hch@infradead.org>
CC: prasanna@in.ibm.com
CC: anil.s.keshavamurthy@intel.com
CC: davem@davemloft.net
---
 include/asm-x86/kdebug.h     |   12 ++++++++++++
 include/asm-x86/kprobes_32.h |    9 ---------
 include/asm-x86/kprobes_64.h |    9 ---------
 3 files changed, 12 insertions(+), 18 deletions(-)

Index: linux-2.6-lttng/include/asm-x86/kdebug.h
===================================================================
--- linux-2.6-lttng.orig/include/asm-x86/kdebug.h	2007-11-02 15:01:53.000000000 -0400
+++ linux-2.6-lttng/include/asm-x86/kdebug.h	2007-11-02 15:02:00.000000000 -0400
@@ -3,6 +3,9 @@
 
 #include <linux/notifier.h>
 
+#include <linux/ptrace.h>
+#include <asm/system.h>
+
 struct pt_regs;
 
 /* Grossly misnamed. */
@@ -30,4 +33,13 @@ extern void dump_pagetable(unsigned long
 extern unsigned long oops_begin(void);
 extern void oops_end(unsigned long);
 
+/* trap3/1 are intr gates for kprobes.  So, restore the status of IF,
+ * if necessary, before executing the original int3/1 (trap) handler.
+ */
+static inline void restore_interrupts(struct pt_regs *regs)
+{
+	if (regs->eflags & IF_MASK)
+		local_irq_enable();
+}
+
 #endif
Index: linux-2.6-lttng/include/asm-x86/kprobes_32.h
===================================================================
--- linux-2.6-lttng.orig/include/asm-x86/kprobes_32.h	2007-11-02 15:01:53.000000000 -0400
+++ linux-2.6-lttng/include/asm-x86/kprobes_32.h	2007-11-02 15:02:00.000000000 -0400
@@ -79,15 +79,6 @@ struct kprobe_ctlblk {
 	struct prev_kprobe prev_kprobe;
 };
 
-/* trap3/1 are intr gates for kprobes.  So, restore the status of IF,
- * if necessary, before executing the original int3/1 (trap) handler.
- */
-static inline void restore_interrupts(struct pt_regs *regs)
-{
-	if (regs->eflags & IF_MASK)
-		local_irq_enable();
-}
-
 extern int kprobe_exceptions_notify(struct notifier_block *self,
 				    unsigned long val, void *data);
 extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
Index: linux-2.6-lttng/include/asm-x86/kprobes_64.h
===================================================================
--- linux-2.6-lttng.orig/include/asm-x86/kprobes_64.h	2007-11-02 15:02:10.000000000 -0400
+++ linux-2.6-lttng/include/asm-x86/kprobes_64.h	2007-11-02 15:02:22.000000000 -0400
@@ -72,15 +72,6 @@ struct kprobe_ctlblk {
 	struct prev_kprobe prev_kprobe;
 };
 
-/* trap3/1 are intr gates for kprobes.  So, restore the status of IF,
- * if necessary, before executing the original int3/1 (trap) handler.
- */
-static inline void restore_interrupts(struct pt_regs *regs)
-{
-	if (regs->eflags & IF_MASK)
-		local_irq_enable();
-}
-
 extern int post_kprobe_handler(struct pt_regs *regs);
 extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
 extern int kprobe_handler(struct pt_regs *regs);

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  parent reply	other threads:[~2007-11-13 19:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13 18:58 [patch 0/8] Immediate Values (now with merged x86 support) Mathieu Desnoyers
2007-11-13 18:58 ` [patch 1/8] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-11-13 18:58 ` [patch 2/8] Immediate Values - Kconfig menu in EMBEDDED Mathieu Desnoyers
2007-11-13 18:58 ` Mathieu Desnoyers [this message]
2007-11-13 18:58 ` [patch 4/8] Add asm-compat.h to x86 Mathieu Desnoyers
2007-11-13 19:05   ` H. Peter Anvin
2007-11-13 20:37     ` [patch 4/8] Add asm-compat.h to x86 -> use new asm.h instead Mathieu Desnoyers
2007-11-13 18:58 ` [patch 5/8] Immediate Values - x86 Optimization Mathieu Desnoyers
2007-11-13 19:07   ` H. Peter Anvin
2007-11-13 19:24     ` Mathieu Desnoyers
2007-11-13 19:36       ` H. Peter Anvin
2007-11-13 19:45         ` Mathieu Desnoyers
2007-11-13 19:56           ` H. Peter Anvin
2007-11-13 20:40             ` [patch 5/8] Immediate Values - x86 Optimization (update) Mathieu Desnoyers
2007-11-13 21:26               ` H. Peter Anvin
2007-11-13 22:02                 ` Mathieu Desnoyers
2007-11-13 22:35                   ` H. Peter Anvin
2007-11-14  0:34                     ` Mathieu Desnoyers
2007-11-14  1:02                       ` H. Peter Anvin
2007-11-14  1:44                         ` [patch 5/8] Immediate Values - x86 Optimization (update 2) Mathieu Desnoyers
2007-11-14  2:58                           ` H. Peter Anvin
2007-11-14 14:16                             ` Mathieu Desnoyers
2007-11-14 18:52                             ` [PATCH] Immediate Values x86 Optimization Declare Discarded Instruction Mathieu Desnoyers
2007-11-14 19:00                               ` H. Peter Anvin
2007-11-14 19:16                                 ` [PATCH] Add __discard section to x86 Mathieu Desnoyers
2007-11-14 19:33                                   ` H. Peter Anvin
2007-11-15  3:08   ` [patch 5/8] Immediate Values - x86 Optimization Rusty Russell
2007-11-15  4:06     ` Mathieu Desnoyers
2007-11-15  4:45       ` Rusty Russell
2007-11-15  5:37         ` Mathieu Desnoyers
2007-11-15 11:06           ` Rusty Russell
2007-11-16 14:03             ` [patch 5/8] Immediate Values - x86 Optimization (simplified) Mathieu Desnoyers
2007-11-18 23:11               ` Rusty Russell
2007-11-19 14:28                 ` Mathieu Desnoyers
2007-11-19 23:06                   ` Rusty Russell
2007-11-20 17:02                     ` Mathieu Desnoyers
2007-11-19 19:15                 ` Mathieu Desnoyers
2007-11-13 18:58 ` [patch 6/8] Immediate Values - Powerpc Optimization Mathieu Desnoyers
2007-11-13 18:58 ` [patch 7/8] Immediate Values - Documentation Mathieu Desnoyers
2007-11-13 18:58 ` [patch 8/8] Scheduler Profiling - Use Immediate Values Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071113190040.090133515@polymtl.ca \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasanna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox