Re: [PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [3/3] fix section mismatch in init_memory_mapping

Andrew Morton
2007-11-16T01:00:33Z

On Thu, 15 Nov 2007 19:36:39 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

>
> Changes __meminit to __init_refok.
> ==
> WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to
> .init.text:find_e820_area (between 'init_memory_mapping' and 'arch_add_memory')
> ==
>
> Changelog:
> * changes __init_refok from find_early_table_space() to
> init_memory_mapping().
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> arch/x86/mm/init_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.24-rc2-mm1/arch/x86/mm/init_64.c
> ===================================================================
> --- linux-2.6.24-rc2-mm1.orig/arch/x86/mm/init_64.c
> +++ linux-2.6.24-rc2-mm1/arch/x86/mm/init_64.c
> @@ -347,7 +347,7 @@ static void __init find_early_table_spac
> /* Setup the direct mapping of the physical memory at PAGE_OFFSET.
> This runs before bootmem is initialized and gets pages directly from the
> physical memory. To access them they are temporarily mapped. */
> -void __meminit init_memory_mapping(unsigned long start, unsigned long end)
> +void __init_refok init_memory_mapping(unsigned long start, unsigned long end)
> {
> unsigned long next;
>

again, I _think_ this fixes a bug in mainline. Can you check that please?