Re: 2.6.24-rc2-mm1 -- strange apparent network failures

Andrew Morgan
2007-11-18T01:57:40Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kevin Winchester wrote:
> However, I got around the problem by making the code change manually -
> and my network connection is now working. Looking at the code being
> bypassed:
>
> if (pE.cap[i] || pP.cap[i] || pP.cap[i])
>
> looks somewhat weird as it is testing the same condition twice. Should
> it have been:
>
> if (pE.cap[i] || pP.cap[i] || pI.cap[i])

Yes, that was also a bug. However, upon reflection (and as per my "0 &&"
hack), I now believe these few lines of code are problematic in general.

Thanks for reporting this bug. I'll post a more clear patch (that isn't
GPG'd).

Cheers

Andrew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHP5vy+bHCR3gb8jsRAliTAKCvCsfZuNN7Og57S0s8O4SZNveSUwCgq4VP
vHUE/S+x09l5I24E2/rmLj4=
=JaWT
-----END PGP SIGNATURE-----