Re: broken suspend [Was: 2.6.24-rc2-mm1]

Jiri Slaby
2007-11-18T22:27:21Z

Aah, we probably should let coretemp people known.

Whole thread:
http://marc.info/?t=119507205800001&r=1&w=2

On 11/18/2007 08:09 PM, Jiri Slaby wrote:
> On 11/18/2007 06:07 PM, Alan Stern wrote:
>> You'll get more useful results if you redo your changes to
>> notifier_call_chain(). Have it print out the address of the routine
>> _before_ making the call, and don't limit it to 20. That way you'll
>> know exactly which notifier routine ends up hanging.
>
> The problem is, that notifier_call_chain is called again and again zillion times
> by somebody else...
>
> Anyway you led me to another idea:
> * _cpu_down
> printk("%s: u\n", __func__);
> BUBAK=1;
> /* CPU is completely dead: tell everyone. Too late to complain. */
> if (raw_notifier_call_chain(&cpu_chain, CPU_DEAD | 0x88000 | mod,
> hcpu) == NOTIFY_BAD)
> BUG();
> BUBAK=0;
> -----
> * notifier_call_chain
> unsigned int a = val & 0x88000;
> unsigned int yes = a == 0x88000;
>
> nb = rcu_dereference(*nl);
>
> if (a && a != 0x88000)
> printk("Somebody calls with val: %lx\n", val);
> else
> val &= ~0x88000;
>
> while (nb && nr_to_call) {
> next_nb = rcu_dereference(nb->next);
> if (unlikely(BUBAK && yes))
> printk("%s: %p\n", __func__, nb->notifier_call);
> ret = nb->notifier_call(nb, val, v);
> -----
> gives coretemp_cpu_callback -> coretemp_device_remove ->
> platform_device_unregister, so coretemp seems to be what I have and you don't.

Just in case you are curious: