public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Miller <davem@davemloft.net>
Cc: clameter@sgi.com, netdev@vger.kernel.org,
	herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org
Subject: Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench
Date: Wed, 14 Nov 2007 05:14:27 +1100	[thread overview]
Message-ID: <200711140514.28159.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20071113.221242.153352652.davem@davemloft.net>

On Wednesday 14 November 2007 17:12, David Miller wrote:
> From: Nick Piggin <nickpiggin@yahoo.com.au>
> Date: Wed, 14 Nov 2007 04:36:24 +1100
>
> > On Wednesday 14 November 2007 12:58, David Miller wrote:
> > > I suspect the issue is about having a huge skb->data linear area for
> > > TCP sends over loopback.  We're likely getting a much smaller
> > > skb->data linear data area after the patch in question, the rest using
> > > the sk_buff scatterlist pages which are a little bit more expensive to
> > > process.
> >
> > It didn't seem to be noticeable at 1 client. Unless scatterlist
> > processing is going to cause cacheline bouncing, I don't see why this
> > hurts more as you add CPUs?
>
> Is your test system using HIGHMEM?
>
> That's one thing the page vector in the sk_buff can do a lot,
> kmaps.

No, it's an x86-64, so no highmem.

What's also interesting is that SLAB apparently doesn't have this
condition. The first thing that sprung to mind is that SLAB caches
order > 0 allocations, while SLUB does not. However if anything,
that should actually favour the SLUB numbers if network is avoiding
order > 0 allocations.

I'm doing some oprofile runs now to see if I can get any more info.

  reply	other threads:[~2007-11-14  6:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09 12:36 2.6.24-rc2 slab vs slob tbench numbers Nick Piggin
2007-11-09 15:15 ` Christoph Lameter
2007-11-09 17:49   ` Christoph Lameter
2007-11-09 23:46     ` 2.6.24-rc2: Network commit causes SLUB performance regression with tbench Christoph Lameter
2007-11-10  1:29       ` Nick Piggin
2007-11-10  3:28         ` Nick Piggin
2007-11-12 19:44         ` Christoph Lameter
2007-11-13 11:41           ` Nick Piggin
2007-11-14  1:58             ` David Miller
2007-11-13 17:36               ` Nick Piggin
2007-11-14  6:12                 ` David Miller
2007-11-13 18:14                   ` Nick Piggin [this message]
2007-11-14  6:37                     ` David Miller
2007-11-13 22:27                       ` Nick Piggin
2007-11-13 22:55                         ` Nick Piggin
2007-11-14 11:10                         ` David Miller
2007-11-13 23:39                           ` Nick Piggin
2007-11-14 11:48                           ` Herbert Xu
2007-11-14  0:02                             ` Nick Piggin
2007-11-14 12:10                               ` David Miller
2007-11-14 18:33                                 ` Christoph Lameter
2007-11-14 23:46                             ` David Miller
2007-11-15  0:21                               ` Nick Piggin
2007-11-15  0:27                                 ` David Miller
2007-11-15  1:03                               ` Christoph Lameter
2007-11-15  1:11                                 ` Herbert Xu
2007-11-15  1:47                                   ` Nick Piggin
2007-11-12 20:13 ` 2.6.24-rc2 slab vs slob tbench numbers Matt Mackall
2007-11-13 11:44   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711140514.28159.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=clameter@sgi.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox