From: Randy Dunlap <randy.dunlap@oracle.com>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Willy Tarreau <w@1wt.eu>,
"Julio M. Merino Vidal" <jmerino@ac.upc.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove bashisms from scripts/extract-ikconfig
Date: Wed, 14 Nov 2007 15:44:26 -0800 [thread overview]
Message-ID: <20071114154426.2443eb50.randy.dunlap@oracle.com> (raw)
In-Reply-To: <alpine.DEB.0.99.0706092211210.8312@foobar-g4>
Hi Christian,
Does the patch below satisfy your needs here?
Thanks,
~Randy
---
From: Christian Kujau <lists@nerdbynature.de>
Remove bashisms from scripts/extract-ikconfig (function and
typeset words).
Tested under dash v0.5.4 (latest/current).
Signed-off-by: Christian Kujau <lists@nerdbynature.de>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
scripts/extract-ikconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.24-rc2-git2.orig/scripts/extract-ikconfig
+++ linux-2.6.24-rc2-git2/scripts/extract-ikconfig
@@ -8,8 +8,9 @@ test -e $binoffset || cc -o $binoffset .
IKCFG_ST="0x49 0x4b 0x43 0x46 0x47 0x5f 0x53 0x54"
IKCFG_ED="0x49 0x4b 0x43 0x46 0x47 0x5f 0x45 0x44"
-function dump_config {
- typeset file="$1"
+
+dump_config() {
+ file="$1"
start=`$binoffset $file $IKCFG_ST 2>/dev/null`
[ "$?" != "0" ] && start="-1"
@@ -27,7 +28,6 @@ function dump_config {
exit 0
}
-
usage()
{
echo " usage: extract-ikconfig [b]zImage_filename"
next prev parent reply other threads:[~2007-11-14 23:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 19:22 [PATCH] Remove bashisms from scripts/extract-ikconfig Christian Kujau
2007-06-09 19:26 ` Julio M. Merino Vidal
2007-06-09 19:34 ` Christian Kujau
2007-06-09 19:39 ` Julio M. Merino Vidal
2007-06-09 19:53 ` Willy Tarreau
2007-06-09 20:14 ` Christian Kujau
2007-11-14 23:44 ` Randy Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-12 18:39 [PATCH] remove " Werner Almesberger
2008-11-12 19:13 ` Randy Dunlap
2008-11-22 11:24 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114154426.2443eb50.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jmerino@ac.upc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox